When copying ServiceTemplate copy only direct_custom_buttons

[ZitaNemeckova]

Fixes #18954

Based on #18494 (comment)

Steps to reproduce:

st = ServiceTemplate.create(:name => "ServiceTemplate")
cb = CustomButton.create(:name => "CustomButton", :applies_to => st)
service = Service.create(:name => "Service", :service_template_id => st.id)
service.save!
service_cb = CustomButton.create(:name => "CustomButton", :applies_to => service)
st.template_copy("Copy")
copy = ServiceTemplate.find_by(:name => "Copy")
copy_of_copy = copy.template_copy

Before:

       16: from app/models/service_template/copy.rb:10:in `block (2 levels) in template_copy'
       15: from app/models/service_template/copy.rb:10:in `each'
       14: from app/models/service_template/copy.rb:10:in `block (3 levels) in template_copy'
       13: from app/models/service_template/copy.rb:23:in `custom_button_copy'
       12: from app/models/custom_button.rb:233:in `copy'
       11: from app/models/custom_button.rb:233:in `tap'
       10: from activerecord (5.1.7) lib/active_record/suppressor.rb:46:in `save!'
        9: from activerecord (5.1.7) lib/active_record/transactions.rb:313:in `save!'
        8: from activerecord (5.1.7) lib/active_record/transactions.rb:381:in `with_transaction_returning_status'
        7: from activerecord (5.1.7) lib/active_record/transactions.rb:210:in `transaction'
        6: from activerecord (5.1.7) lib/active_record/connection_adapters/abstract/database_statements.rb:233:in `transaction'
        5: from activerecord (5.1.7) lib/active_record/transactions.rb:384:in `block in with_transaction_returning_status'
        4: from activerecord (5.1.7) lib/active_record/transactions.rb:313:in `block in save!'
        3: from activerecord (5.1.7) lib/active_record/attribute_methods/dirty.rb:43:in `save!'
        2: from activerecord (5.1.7) lib/active_record/validations.rb:50:in `save!'
        1: from activerecord (5.1.7) lib/active_record/validations.rb:78:in `raise_validation_error'
ActiveRecord::RecordInvalid (Validation failed: CustomButton: Name has already been taken, CustomButton: Description has already been taken)

After:
It works and copy_of_copy is created :)

@gmcculloug Please have look, thanks :)

cc @d-m-u

[d-m-u]

Can you put a test in for copy of copy, as well, please?

[gmcculloug]

👍 Looks good. Thanks @ZitaNemeckova and @himdel

[ZitaNemeckova]

@d-m-u Added :)

[d-m-u]

Thanks!

[miq-bot]

Checked commit ZitaNemeckova@bb47290 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍