Add custom_button and custom_button_set copy to service_template copy #18494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
force-pushed
the
custom_button_copy_for_service_templates
branch
2 times, most recently
from
ce894ab
to
d8395db
Compare
bdunne
reviewed
Feb 27, 2019
bdunne
reviewed
Feb 27, 2019
gmcculloug
reviewed
Feb 27, 2019
d-m-u
force-pushed
the
custom_button_copy_for_service_templates
branch
from
d8395db
to
8f0d26a
Compare
|
Checked commits d-m-u/manageiq@303322f~...8f0d26a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_reviewer @tinaafitz |
tinaafitz
approved these changes
Feb 27, 2019
himdel
reviewed
Jul 10, 2019
| template.add_resource(resource, sr) | ||
| end | ||
| service_resources.each { |service_resource| resource_copy(service_resource, template) } | ||
| custom_buttons.each { |custom_button| custom_button_copy(custom_button, template) } |
There was a problem hiding this comment.
I think this is the bug ... custom_buttons are not custom buttons assigned to this service template.
If you want that, you need to use direct_custom_buttons.
custom_buttons gives you those, and every single custom button for any ServiceTemplate .. and you don't want to copy those.
(that should fix #18954)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of copying service templates (#18450) we should copy custom buts and custom_but_sets on those templates so that's what this does.
The template copy itself got merged yesterday.
Probs best viewed by commit cause the second commit is performance enhancement on tests from the original merge (calling find_by only once per test)