Allow ssh auth for RHV #18805
Merged
Allow ssh auth for RHV #18805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
May 23, 2019
agrare
reviewed
May 23, 2019
|
@fdupont-redhat big 👍 from me on removing those provider specific methods |
ghost
mentioned this pull request
agrare
reviewed
May 23, 2019
|
Checked commits fabiendupont/manageiq@8820df1~...988d3cf with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
May 23, 2019
simaishi
pushed a commit
that referenced
this pull request
May 23, 2019
…host_auth Allow ssh auth for RHV (cherry picked from commit 6cb8d78) https://bugzilla.redhat.com/show_bug.cgi?id=1712135
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, RHV conversion hosts only supported userid/password authentication. With the conversion host management UI, we're now using SSH private key. This PR updates the method that build the MiqSshUtil args to not look at the provider type, but the authentication type.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1708739