Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAMMER] [V2V] Allow ssh auth for RHV #18800

Closed

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2019

Previously, RHV conversion hosts only supported userid/password authentication. With the conversion host management UI, we're now using SSH private key. This PR updates the method that build the MiqSshUtil args to not look at the provider type, but the authentication type.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1712135

@ghost ghost changed the title V2v allow ssh auth for rhevm [V2V] Allow ssh auth for RHV May 23, 2019
@ghost
Copy link
Author

ghost commented May 23, 2019

@miq-bot add-label transformation, bug, hammer/yes
@miq-bot add-reviewer @djberg96
@miq-bot add-reviewer @agrare

@miq-bot miq-bot requested review from djberg96 and agrare May 23, 2019 13:40
@miq-bot miq-bot changed the title [V2V] Allow ssh auth for RHV [HAMMER] [V2V] Allow ssh auth for RHV May 23, 2019
@agrare agrare self-assigned this May 23, 2019
@miq-bot
Copy link
Member

miq-bot commented May 23, 2019

Checked commits fabiendupont/manageiq@f864049~...e4ba9ed with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Contributor

@djberg96 djberg96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You don't need the explicit returns, but if rubocop doesn't complain, then I'm not going to let that hold it up.

@agrare agrare assigned simaishi and unassigned agrare May 23, 2019
@agrare
Copy link
Member

agrare commented May 23, 2019

@fdupont-redhat which PR is this a backport of?

@ghost
Copy link
Author

ghost commented May 23, 2019

Closing in favor of #18805.

@ghost ghost closed this May 23, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants