Mark rbac_tenant_manage_quotas as MY TENANT FEATURE #18322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
|
@miq-bot add_label hammer/yes |
gtanzillo
reviewed
Jan 3, 2019
app/models/miq_product_feature.rb
Outdated
| @@ -33,7 +33,8 @@ class MiqProductFeature < ApplicationRecord | |||
| REQUIRED_ATTRIBUTES = [:identifier].freeze | |||
| OPTIONAL_ATTRIBUTES = %i(name feature_type description children hidden protected).freeze | |||
| ALLOWED_ATTRIBUTES = (REQUIRED_ATTRIBUTES + OPTIONAL_ATTRIBUTES).freeze | |||
| TENANT_FEATURE_ROOT_IDENTIFIERS = %w(dialog_new_editor dialog_edit_editor dialog_copy_editor dialog_delete rbac_tenant_manage_quotas).freeze | |||
| SELF_TENANT_FEATURE_ROOT_IDENTIFIERS = %w(rbac_tenant_manage_quotas).freeze | |||
There was a problem hiding this comment.
Perhaps MY_TENANT_FEATURE_ROOT_IDENTIFIERS would b a better name
lpichler
changed the title
lpichler
force-pushed
the
add_SELF_TENANT_FEATURE_ROOT_IDENTIFIERS
branch
from
f3e548b
to
e7eb909
Compare
lpichler
force-pushed
the
add_SELF_TENANT_FEATURE_ROOT_IDENTIFIERS
branch
from
e7eb909
to
004333e
Compare
Merged
1 task
simaishi
pushed a commit
that referenced
this pull request
Jan 7, 2019
…IDENTIFIERS Mark rbac_tenant_manage_quotas as MY TENANT FEATURE (cherry picked from commit f57b574) https://bugzilla.redhat.com/show_bug.cgi?id=1468795
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending: #18151
will be used for
This PR is based recent feature called Dynamic product features according to tenants:
Scenario:
Let's have tenant structure:
According to the BZ user alpha needs to have forbidden access to managing quotas for tenant Alpha (user alpha) and allowed to managing quotas.
We can use for this recent feature called Dynamic product features according to tenants
that we will authorise dynamic tenant product features (
rbac_tenant_manage_quotas_tenant_<TENANT ID where we want/don't want to manage tenant quotas >) to access managing quotas of .To accomplish this we need to change places where we are authorising
rbac_tenant_manage_quotas_tenanttorbac_tenant_manage_quotas_tenant_<TENANT ID where we want/don't want to manage tenant quotas >This places are in UI and API in the PRs above
User alpha has this setting in role (rbac_tenant_manage_quotas_tenant is checked just for Omega Tenant)
which will forbid managing for tenant alpha
and allow manage quotas for omega tenant
This is done in UI PR ^.
Links
@miq-bot add_label enhancement, blocker
@miq-bot assign @gtanzillo