Authorise action managing tenant quotas for according tenants in API #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lpichler
force-pushed
the
authorise_manage_tenant_quotas_as_tenant_product_feature_api
branch
from
5db50b5
to
7dc1431
Compare
lpichler
force-pushed
the
authorise_manage_tenant_quotas_as_tenant_product_feature_api
branch
from
7dc1431
to
d1ac3c4
Compare
lpichler
changed the title
lpichler
force-pushed
the
authorise_manage_tenant_quotas_as_tenant_product_feature_api
branch
2 times, most recently
from
f0a6a5d
to
17afdce
Compare
This needs custom behaviour for role validation api requests - this is done by adding method custom_api_user_role_allows_method? in BaseController to decide if certain controller is allowing custom api validation. Authorisation action 'managing tenant quotas' according to tenants needs custom validation this is defined in Api::Subcollections::Quotas(api/subcollections/quotas.rb, included in TenantController) this custom validation is used only if api wants to authorise rbac_tenant_manage_quotas_tenant_<TENANT_ID> permission.
lpichler
force-pushed
the
authorise_manage_tenant_quotas_as_tenant_product_feature_api
branch
from
17afdce
to
a485c9a
Compare
|
@gtanzillo I avoided |
|
@miq-bot add_label hammer/yes, blocker, enhancement |
lpichler
deleted the
authorise_manage_tenant_quotas_as_tenant_product_feature_api
branch
simaishi
pushed a commit
that referenced
this pull request
Jan 7, 2019
…as_tenant_product_feature_api Authorise action managing tenant quotas for according tenants in API (cherry picked from commit fadf393) https://bugzilla.redhat.com/show_bug.cgi?id=1468795
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is PR is needed
This needs custom behaviour for role validation api requests -
this is done by adding method custom_api_user_role_allows_method?
in BaseController to decide if certain controller is allowing custom
api validation.
Authorisation action 'managing tenant quotas' according to tenants
needs custom validation this is defined in
Api::Subcollections::Quotas(api/subcollections/quotas.rb, included inTenantController)this custom validation is used only if api wants to authorise
rbac_tenant_manage_quotas_tenant_
<TENANT_ID>permission.this is used for authorisation of permission 'manage tenant quota' with using dynamic tenant features.
see desricption here ManageIQ/manageiq#18322
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1468795