Introduce support for multi-tab orchestration dialogs #17342
Conversation
|
|
||
| template.parameter_groups.each_with_index do |parameter_group, index| | ||
| add_parameter_group(parameter_group, tab, index + 1) | ||
| if template.respond_to?(:parameter_groups_tabbed) |
There was a problem hiding this comment.
We should not test respond_to? for backward compatibility. The proper way is to introduce parameter_groups_tabbed method in the base template model. Default implementation is to provide a single tab named Basic Information, and allow the subclass to override with multiple tabs.
| end | ||
|
|
||
| Array(tab_data[:param_group]).each_with_index do |param_group, i| | ||
| if defined? param_group.parameters |
There was a problem hiding this comment.
Similarly, can we avoid a test for defined?
Until now it was hard-coded that orchestration service dialog uses a single tab only, named "Basic Information". For some providers, however, this is not too convinient because there are many fields in dialog that can be grouped into multiple tabs. With this commit we allow provider to decide how many tabs to use and what content to put in each tab. New feature is optional and fully backwards compatible. Usage: should provider decide to define custom tabs, it can now override function `tabs` that returns a list of tab specifications. Signed-off-by: Gašper Vrhovšek <gasper.vrhovsek@gmail.com> Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
|
Checked commit miha-plesko@2472424 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Sorry for delay @bzwei, was on PTO. Many thanks for the review, I like your suggestion about introducing common function in the base model. I've also updated the rspec tests to be more readable now. Looking forward to your opinion. |
|
Looks good. Thanks. |
Introduce support for multi-tab orchestration dialogs (cherry picked from commit fd76353) https://bugzilla.redhat.com/show_bug.cgi?id=1584296
|
Gaprindashvili backport details: |
Until now it was hard-coded that orchestration service dialog uses a single tab only, named "Basic Information". For some providers, however, this is not too convinient because there are many fields in dialog that can be grouped into multiple tabs.
With this commit we allow provider to decide how many tabs to use and what content to put in each tab. New feature is optional and fully backwards compatible.
Usage: should provider decide to define custom tabs, it can now override function
tabsthat returns a list of tab specifications.Following screenshot demonstrates how VMware vCloud provider defined three tabs (Basic Information, vApp Networks and Instances)
Original PR: #17289 (@gasper-vrhovsek left company)
Related PR: ManageIQ/manageiq-providers-vmware#242 (relies on this core PR being merged)
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1571758
@miq-bot assign @bzwei
@miq-bot add_label enhancement,provisioning,gaprindashvili/yes
/cc @agrare