Add support for tabbed dialogs #17289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasper-vrhovsek
force-pushed
the
feature/tabbed_service_dialog
branch
3 times, most recently
from
88d6b9a
to
c4532f5
Compare
This enables instatiation of tabbed service dialogs from orchestration templates. Support for tabs must be implemented in the orchestration template as 'parameter_groups_tabbed' method.
gasper-vrhovsek
force-pushed
the
feature/tabbed_service_dialog
branch
from
c4532f5
to
69f70d7
Compare
|
Checked commit gasper-vrhovsek@69f70d7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
cc @bzwei |
|
@gasper-vrhovsek can you show a screenshot of the end result? |
|
@bzwei @agrare please close this PR since @gasper-vrhovsek left the company. I've opened a new PR here #17342 where I'll be happy to go through review process with you guys. Code credit is preserved to him by listing him in @gasper-vrhovsek thanks for implementing, I can confirm it works great in my local environment 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables instatiation of tabbed service dialogs from orchestration
templates. Support for tabs must be implemented in the orchestration
template as 'parameter_groups_tabbed' method.