-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse default value in Service Dialog #16555
Conversation
cc @eclarizio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change to the spec and I think this looks good 👍
@@ -147,7 +150,8 @@ | |||
:category_id => "123", | |||
:category_name => "best category ever", | |||
:category_description => "best category ever" | |||
} | |||
}, | |||
"default_value" => default_values.split(",") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change, but I think this should be hard-coded to %w(one two)
. There's really no way the .split
method is going to change, but I feel like matching the test expected output with what the code is actually doing doesn't really set the expectation correctly.
When serializing the dialog, it should return an array of values rather than a string if force_multi_value is true
9280ce8
to
a613395
Compare
Checked commit jntullo@a613395 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Reverting changes from #16555
Ok @romanblanco, let's try this again 😛
re-opened version of #15878
When serializing the dialog, it should return an array of values rather than a string if
force_multi_value
is trueTested this out via the API:
GET api/service_dialogs/:id
and the result seems to be as expected, as you can see from the
default_values
in the response:@miq-bot assign @gmcculloug
@miq add_label enhancement, services