-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metering reports #16342
Merged
Merged
Add metering reports #16342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
add_metering_reports
branch
from
October 30, 2017 12:29
9654cdc
to
cc73042
Compare
1 task
lpichler
force-pushed
the
add_metering_reports
branch
from
October 30, 2017 13:10
cc73042
to
6ce25db
Compare
- to be able add/edit in UI - restrict column reporting columns(storing report definition)
don`t depend on rates only chargeable field is needed for getting metric value
it is same as fixed compute metric Chargeable field is not used for getting metric value for metering hours metric and for fixed
…tric - we are probably allowing both names of metric
lpichler
force-pushed
the
add_metering_reports
branch
from
October 30, 2017 17:27
6ce25db
to
99cebac
Compare
gtanzillo
approved these changes
Oct 30, 2017
Checked commits lpichler/manageiq@6a2d9d3~...99cebac with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/models/metering_container_image.rb
app/models/metering_container_project.rb
app/models/metering_vm.rb
spec/models/metering_vm_spec.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding metering reports:
Metering for VM
Metering for ContainerProject
Metering for ContainerImage
also:
These reports are most likely like a chargeback reports but without cost.
Difference is also in calculation of used metric - there are used sums instead of averages.
@miq-bot assign @gtanzillo
@miq-bot add_label enhancement, chargeback
Links
UI: ManageIQ/manageiq-ui-classic#2553