Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Metering reports in views #2553

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Allow Metering reports in views #2553

merged 1 commit into from
Oct 31, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Oct 30, 2017 •
edited
Loading

Depends on:

Metering reports are similar like a chargeback report, as were are added in ManageIQ/manageiq#16342

in views there are lot of ifs, so I need to extend them. Otherwise it will break filter tab in metering reports:
screen shot 2017-10-30 at 14 00 23

@miq-bot add_label chargeback, enhancement

@miq-bot assign @mzazrivec

@lpichler lpichler mentioned this pull request Oct 30, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Oct 30, 2017

@lpichler Cannot apply the following label because they are not recognized: chargeback

@lpichler lpichler changed the title Allow Metering reports in views [WIP] Allow Metering reports in views Oct 30, 2017
@miq-bot miq-bot added the wip label Oct 30, 2017
@lpichler lpichler force-pushed the add_metering_to_chargeback_editor branch from edd7a30 to 2560edc Compare October 30, 2017 19:13
@lpichler lpichler changed the title [WIP] Allow Metering reports in views Allow Metering reports in views Oct 30, 2017
@miq-bot miq-bot removed the wip label Oct 30, 2017
@lpichler
Copy link
Contributor Author

@dclarizio @h-kataria

@miq-bot
Copy link
Member

miq-bot commented Oct 30, 2017

Checked commits lpichler/manageiq-ui-classic@2560edc~...b74897b with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 3 offenses detected

app/views/report/_form_filter_chargeback.html.haml

  • ⚠️ - Line 137 - Prefer to_s over string interpolation.
  • ⚠️ - Line 138 - Line is too long. [175/160]
  • ⚠️ - Line 138 - Prefer to_s over string interpolation.

@lpichler lpichler force-pushed the add_metering_to_chargeback_editor branch from b74897b to 2560edc Compare October 30, 2017 21:14
@Fryguy Fryguy closed this Oct 30, 2017
@Fryguy Fryguy reopened this Oct 30, 2017
@Fryguy Fryguy merged commit 60269d4 into ManageIQ:master Oct 31, 2017
@Fryguy Fryguy added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 31, 2017
@chessbyte chessbyte assigned Fryguy and unassigned mzazrivec Oct 31, 2017
@lpichler lpichler deleted the add_metering_to_chargeback_editor branch October 31, 2017 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fryguy Fryguy

Labels
enhancement overview/reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpichler @miq-bot @Fryguy @mzazrivec