Add an inventory_collector_worker base class #16198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
containers_inventory_collector_worker
branch
from
f2500de
to
63faf7c
Compare
agrare
force-pushed
the
containers_inventory_collector_worker
branch
5 times, most recently
from
36a77b9
to
8ee1bb2
Compare
This was referenced Oct 19, 2017
|
This pull request is not mergeable. Please rebase and repush. |
agrare
force-pushed
the
containers_inventory_collector_worker
branch
from
8ee1bb2
to
12ee7ff
Compare
agrare
changed the title
|
@Fryguy @blomquisg @Ladas can you guys review? |
Ladas
approved these changes
Oct 24, 2017
agrare
force-pushed
the
containers_inventory_collector_worker
branch
from
12ee7ff
to
2d75a49
Compare
|
Checked commits agrare/manageiq@49c8bb1~...2d75a49 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manageiq/providers/base_manager/inventory_collector_worker.rb
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic inventory collector worker which can be used for sending update-driven inventory payloads to a RefreshWorker for saving.
The goal here is to use the Kubernetes watch_pods() API to ensure that we never miss a pod if it is created and deleted while a refresh is running (already real world issue with customers).
Required for ManageIQ/manageiq-providers-kubernetes#129 and ManageIQ/manageiq-providers-openshift#52