Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Openshift InventoryCollectorWorker #52

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

agrare
Copy link
Member

@agrare agrare commented Oct 13, 2017

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Oct 26, 2017

Checked commit agrare@1afe334 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moolitayer moolitayer merged commit 89c3354 into ManageIQ:master Oct 30, 2017
@cben
Copy link
Contributor

cben commented Oct 30, 2017

🍰 ☕

@agrare agrare deleted the inventory_collector_worker branch October 30, 2017 19:26
@moolitayer moolitayer added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants