Commits on Feb 17, 2017

1. Configure the secret key when starting the embedded ansible service …

   Before this change if someone called start before calling configure,
   they would get into a bad state because we would not have the secret
   key saved.
   
   This would lead tower to use the one on the filesystem which was
   generated at RPM install time which means that every build would
   have access to that key.
   
   This change makes sure that start also does the work of configure
   if configure had not been called yet.

   

   carbonin committed Feb 17, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 3d7229f
   • Browse repository at this point

   Copy the full SHA

   3d7229f View commit details

   Browse the repository at this point in the history

2. Implement a better worker lifecycle for the embedded_ansible_worker …

   Only heartbeat when the locally running ansible service is alive.
   
   Also, start the service if it isn't alive and all the processes are
   not running (EmbeddedAnsible.running?).
   
   We are aware that this opens the potential for a race condition when
   the worker is killed and the server starts a replacement before the
   original worker is completely down.
   
   The combination of implementing EmbeddedAnsibleWorker#kill as #stop
   and starting the service every time we can't heartbeat should allow
   the new worker to recover even if the stop is run after the new worker
   runs EmbeddedAnsible.start
   
   If this does become a problem we will need to implement some new
   mechanisms for dealing with such "singleton" workers.

   

   carbonin committed Feb 17, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 678c4e7
   • Browse repository at this point

   Copy the full SHA

   678c4e7 View commit details

   Browse the repository at this point in the history