Properly monitor the embedded ansible service #13978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change if someone called start before calling configure, they would get into a bad state because we would not have the secret key saved. This would lead tower to use the one on the filesystem which was generated at RPM install time which means that every build would have access to that key. This change makes sure that start also does the work of configure if configure had not been called yet.
Only heartbeat when the locally running ansible service is alive. Also, start the service if it isn't alive and all the processes are not running (EmbeddedAnsible.running?). We are aware that this opens the potential for a race condition when the worker is killed and the server starts a replacement before the original worker is completely down. The combination of implementing EmbeddedAnsibleWorker#kill as #stop and starting the service every time we can't heartbeat should allow the new worker to recover even if the stop is run after the new worker runs EmbeddedAnsible.start If this does become a problem we will need to implement some new mechanisms for dealing with such "singleton" workers.
Fryguy
reviewed
Feb 17, 2017
| if EmbeddedAnsible.running? | ||
| _log.info("#{log_prefix} supervisord is ok!") | ||
| if EmbeddedAnsible.alive? | ||
| heartbeat |
There was a problem hiding this comment.
Doesn't this introduce a delay? That is, you have to wait for the worker heartbeat detection to stop the worker.
There was a problem hiding this comment.
@Fryguy yeah, we'll keep trying to fix the situation by reconfiguring and starting the service via the setup script until the worker hasn't responded. It was the simplest thing to do until we figure out what ways the service can fail.
|
Checked commits carbonin/manageiq@3d7229f~...678c4e7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly handles implementing a better worker lifecycle (start, do_work, kill) for the
EmbeddedAnsibleWorkerFor this we should only heartbeat when the locally running ansible service is alive and start the service if it isn't alive and all the processes are not running (EmbeddedAnsible.running?).
We are aware that this opens the potential for a race condition when the worker is killed and the server starts a replacement before the original worker is completely down.
The combination of implementing
EmbeddedAnsibleWorker#killas#stopand starting the service every time we can't heartbeat should allow the new worker to recover even if the stop is run after the new worker runsEmbeddedAnsible.startIf this does become a problem we will need to implement some new mechanisms for dealing with such "singleton" workers.