Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for service dialog refreshing every time a dropdown item is selected #12718

Merged
merged 1 commit into from
Nov 17, 2016
Merged

Fix for service dialog refreshing every time a dropdown item is selected #12718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/assets/javascripts/dialog_field_refresh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ var dialogFieldRefresh = {
$('#' + fieldName).selectpicker('val', selectedValue);
}
miqSelectPickerEvent(fieldName, url, {callback: function() {
dialogFieldRefresh.triggerAutoRefresh(fieldId, triggerAutoRefresh || "true");
dialogFieldRefresh.triggerAutoRefresh(fieldId, triggerAutoRefresh);
return true;
}});
},
Expand Down Expand Up @@ -168,7 +168,7 @@ var dialogFieldRefresh = {


triggerAutoRefresh: function(fieldId, trigger) {
if (trigger === "true") {
if (Boolean(trigger) === true) {
parent.postMessage({fieldId: fieldId}, '*');
}
},
Expand Down
34 changes: 28 additions & 6 deletions spec/javascripts/dialog_field_refresh_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,14 +423,36 @@ describe('dialogFieldRefresh', function() {
expect(window.miqSelectPickerEvent).toHaveBeenCalledWith('fieldName', 'url', {callback: jasmine.any(Function)});
});

it('triggers the auto refresh when the drop down changes', function() {
dialogFieldRefresh.initializeDialogSelectPicker(fieldName, fieldId, selectedValue, url);
it('triggers autorefresh with true only when triggerAutoRefresh arg is true', function() {
dialogFieldRefresh.initializeDialogSelectPicker(fieldName, fieldId, selectedValue, url, 'true');
expect(dialogFieldRefresh.triggerAutoRefresh).toHaveBeenCalledWith(fieldId, 'true');
});
});

describe('#triggerAutoRefresh', function() {
beforeEach(function() {
spyOn(parent, 'postMessage');
});

context('when the trigger passed in falsy', function() {
it('does not post any messages', function() {
dialogFieldRefresh.triggerAutoRefresh(123, "");
expect(parent.postMessage).not.toHaveBeenCalled();
});
});

context('when the trigger passed in is the string "true"', function() {
it('posts a message', function() {
dialogFieldRefresh.triggerAutoRefresh(123, "true");
expect(parent.postMessage).toHaveBeenCalledWith({fieldId: 123}, '*');
});
});

it('triggers autorefresh with "false" when triggerAutoRefresh arg is false', function() {
dialogFieldRefresh.initializeDialogSelectPicker(fieldName, fieldId, selectedValue, url, 'false');
expect(dialogFieldRefresh.triggerAutoRefresh).toHaveBeenCalledWith(fieldId, 'false');
context('when the trigger passed in is true', function() {
it('posts a message', function() {
dialogFieldRefresh.triggerAutoRefresh(123, true);
expect(parent.postMessage).toHaveBeenCalledWith({fieldId: 123}, '*');
});
});
});
});
});