Fix for service dialog refreshing every time a dropdown item is selected #12718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit eclarizio@76229c9 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
👍 Looks good to me |
chessbyte
pushed a commit
that referenced
this pull request
Nov 17, 2016
Fix for service dialog refreshing every time a dropdown item is selected (cherry picked from commit 2cd0d32) https://bugzilla.redhat.com/show_bug.cgi?id=1396167
|
Euwe Backport details: $ git log -1
commit 8ffcaef773ad1be5deb7dfa2c00dcf839335563a
Author: Greg McCullough <gmccullo@redhat.com>
Date: Thu Nov 17 14:39:48 2016 -0500
Merge pull request #12718 from eclarizio/BZ1396167
Fix for service dialog refreshing every time a dropdown item is selected
(cherry picked from commit 2cd0d32b042751d1af5c153ef1b554a47ca7f36c)
https://bugzilla.redhat.com/show_bug.cgi?id=1396167 |
|
@simaishi Need Darga BZ for https://bugzilla.redhat.com/show_bug.cgi?id=1396167 |
chessbyte
pushed a commit
that referenced
this pull request
Dec 13, 2016
Fix for service dialog refreshing every time a dropdown item is selected (cherry picked from commit 2cd0d32) https://bugzilla.redhat.com/show_bug.cgi?id=1404403
|
Darga Backport details: $ git log -1
commit f8dde423da0ef20c2584188cd83ef2f9de7582b2
Author: Greg McCullough <gmccullo@redhat.com>
Date: Thu Nov 17 14:39:48 2016 -0500
Merge pull request #12718 from eclarizio/BZ1396167
Fix for service dialog refreshing every time a dropdown item is selected
(cherry picked from commit 2cd0d32b042751d1af5c153ef1b554a47ca7f36c)
https://bugzilla.redhat.com/show_bug.cgi?id=1404403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem in the below linked BZ was that
""was being passed in as thetrigger_auto_refreshproperty, and then was getting||'d with"true", and so it was always causing a refresh.This fix will ensure that the triggerAutoRefresh method will be able to handle any values that come through even if they are not explicitly "false" or "true", and coerce them into
falseortrue.Links
https://bugzilla.redhat.com/show_bug.cgi?id=1396167
@miq-bot assign @gmcculloug
/cc @syncrou Can you review this for me, please?