-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Move frontend deps from bower to npm #12581
Conversation
bower.json -> package.json:
|
|
patternfly-sass has npm for 3.14.1 ✔️ |
TODO |
for rebase..
``` jq '.dependencies' bower.json | sed -e '1d' -e '$d' -e 's/^\s*"/npm install --save '\''/' -e 's/": "/@/' -e 's/",$/'\''/' -e 's/ --save \(.*\)$/& || echo \1 >> fail/' | sh ``` Only things that had the same name and version available in npm.
jquery-1.8 jquery.observe_field spice-html5-bower (version goes from 0.1.6.2 to 1.6.2, because npm doesn't like the fourth number) xml_display
kubernetes-topology-graph - kubernetes-ui/topology-graph#26 patternfly-timeline - patternfly/patternfly-timeline#28
reverts that commit by sticking the new versions to the right place
because 0.3.10 is not in npm close enough https://github.com/nire0510/qs/compare/v0.3.10...v0.4.6?w=1
Checked commits https://github.com/himdel/manageiq/compare/5dafcdc32b57f2c339b2ac47254e7d0a388f0e65~...46da211ecc5fffa0e21ad4c56b53bb7b43c648ba with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
patternfly-timeline npm is without |
require is not defined - |
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
Please re-create PR in https://github.com/ManageIQ/manageiq-ui-classic |
Bower is slowly dying (no activity whatsoever between Jul 5 and Nov 6 for example), SUI has already moved from bower to npm (yarn), following suit..
checklist:
node_modules