[WIP] Remove bower via bower-away #2571

Fryguy · 2017-10-31T05:02:13Z

This migrates the project from bower to yarn via the bower-away tool as recommended by bower themselves. https://bower.io/blog/2017/how-to-migrate-away-from-bower/

@himdel @martinpovolny Please review

TODO: Figure out what to do with the rest of these references to bower

.eslintignore:6:vendor/assets/bower_components/
.eslintrc.json:25:    "Promise": false, // bower: es6-shim
.eslintrc.json:26:    "_": false, // bower: lodash
.eslintrc.json:28:    "angular": false, // bower: angular
.eslintrc.json:29:    "c3": false, // bower: c3
.eslintrc.json:30:    "d3": false, // bower: d3
.eslintrc.json:32:    "moment": false, // bower: moment
.eslintrc.json:33:    "numeral": false, // bower: numeral
.eslintrc.json:34:    "sprintf": false // bower: sprintf
.gitignore:18:vendor/assets/bower_components/
.travis.yml:10:  - vendor/assets/bower_components
.travis.yml:23:- cp bower.json vendor/assets/bower_components
app/assets/javascripts/remote_consoles/spice.js:2://= require spice-html5-bower
config/initializers/assets.rb:1:Rails.application.config.assets.paths << ManageIQ::UI::Classic::Engine.root.join('vendor', 'assets', 'bower_components')
config/initializers/assets.rb:17:  spice-html5-bower
config/initializers/assets.rb:18:  spice-html5-bower/spiceHTML5/spicearraybuffer.js
lib/tasks/manageiq/ui_tasks.rake:2:  task :bower do
lib/tasks/manageiq/ui_tasks.rake:4:      system("bower update --allow-root -F --config.analytics=false") || abort("\n== bower install failed ==")
lib/tasks/manageiq/ui_tasks.rake:18:    Rake::Task['update:bower'].invoke

ohadlevy · 2017-10-31T09:05:09Z

thanks @Fryguy looks like a positive change, do you happen to know if spec/manageiq/lib/manageiq/environment.rb is currently used? (it has references to updating bower via bin/update).

himdel · 2017-10-31T12:46:13Z

@ohadlevy Yes, that code is called during bin/update.

himdel · 2017-10-31T12:52:37Z

@Fryguy re the TODO:

Keep:

.eslintignore:6:vendor/assets/bower_components/
.gitignore:18:vendor/assets/bower_components/
config/initializers/assets.rb:1:Rails.application.config.assets.paths << ManageIQ::UI::Classic::Engine.root.join('vendor', 'assets', 'bower_components')

.. still using that directory, kept updated by that postinstall

.eslintrc.json:25:    "Promise": false, // bower: es6-shim
.eslintrc.json:26:    "_": false, // bower: lodash
.eslintrc.json:28:    "angular": false, // bower: angular
.eslintrc.json:29:    "c3": false, // bower: c3
.eslintrc.json:30:    "d3": false, // bower: d3
.eslintrc.json:32:    "moment": false, // bower: moment
.eslintrc.json:33:    "numeral": false, // bower: numeral
.eslintrc.json:34:    "sprintf": false // bower: sprintf

.. those are just hints on where those globals come from .. until we actually stop using bower packages, I'd keep them.

app/assets/javascripts/remote_consoles/spice.js:2://= require spice-html5-bower
config/initializers/assets.rb:17:  spice-html5-bower
config/initializers/assets.rb:18:  spice-html5-bower/spiceHTML5/spicearraybuffer.js

.. the package name stays the same

Remove:

lib/tasks/manageiq/ui_tasks.rake:2:  task :bower do
lib/tasks/manageiq/ui_tasks.rake:4:      system("bower update --allow-root -F --config.analytics=false") || abort("\n== bower install failed ==")
lib/tasks/manageiq/ui_tasks.rake:18:    Rake::Task['update:bower'].invoke

..no need to run bower now .. (and I'm not aware of anybody using update:bower directly (nobody should IMO), so no need to keep a compatibility task, I assume).

.travis.yml:10:  - vendor/assets/bower_components
.travis.yml:23:- cp bower.json vendor/assets/bower_components

.. we can just drop the bower-caching on travis I hope, since yarn will cache it for us. Just need to make sure postinstall gets run on travis too.

himdel · 2017-10-31T12:56:53Z

Overall, yeah, I agree it makes sense to drop bower as a tool now if we can do that without breaking anything :).

(Moving away from bower as a package source and mode of use is still a TODO for H-release (uh.. Hammer time?), though the latter should be relatively easy using webpack ProviderPlugin.)

himdel · 2017-10-31T13:00:18Z

Oh, one more note...

We're not really married to vendor/assets/bower_components/, maybe we could just change the asset_path line (config/initializers/assets.rb:1) to reference node_modules/@bower_components and we can drop the postinstall task.

himdel · 2017-10-31T13:15:29Z

error Package "@bower_components/kubernetes-topology-graph@" doesn't have a "version".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

== yarn failed in /home/himdel/manageiq-ui-classic ==

Looks like if the bower package also has a package.json, it needs to be valid :(.

miq-bot · 2017-11-30T13:28:48Z

This pull request is not mergeable. Please rebase and repush.

miq-bot · 2017-12-11T15:54:14Z

This pull request is not mergeable. Please rebase and repush.

martinpovolny · 2017-12-23T17:13:03Z

@himdel, @Fryguy : who will finish this PR? Thx!

Fryguy · 2018-01-09T22:45:01Z

I think it's in @himdel's court because I don't know how to move forward

Fryguy · 2018-01-09T22:54:32Z

I'm basically stuck at this step of bower-away:

05:53:55 ~/dev/manageiq-ui-classic (bower-away *) (2.4.2) ✓ bower-away

# Install dependencies with Yarn

Now install dependencies again with:
$ yarn

If you encounter issues during installation, please try:
$ yarn --ignore-engines

If it also fails, you can try following:
$ yarn --ignore-engines --ignore-scripts && yarn postinstall

You can use this command from now on to install both npm and bower dependencies!

Please call bower-away once more when you're done with this!

05:53:58 ~/dev/manageiq-ui-classic (bower-away *) (2.4.2) ✓ yarn
yarn install v1.2.1
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
error Package "@bower_components/kubernetes-topology-graph@" doesn't have a "version".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Apparently kubernetes-topology-graph is not a valid package because it doesn't have a version. But when I look at the latest, I think it does have it, so maybe we just have to upgrade? https://github.com/kubernetes-ui/topology-graph

miq-bot · 2018-01-09T22:58:11Z

Checked commits Fryguy/manageiq-ui-classic@9ed2cd4~...2eb0e34 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

miq-bot · 2018-01-29T15:50:44Z

This pull request is not mergeable. Please rebase and repush.

himdel · 2018-01-30T17:21:09Z

Looking into this, so far..

some dependency is trying to install phantomjs and fails miserably (can be skipped with yarn --ignore-optional but..)
some dependency is trying to run node-sass and fails
yarn is very friendly in that when if fails installing, it doesn't quite bother to tell you why it ran the thing that failed or even which package it came from (EDIT: --verbose almost helps :))
npm can't handle the syntax, when it sees package#~2.1.1 it tries to git checkout ~2.1.1 (but that's a non-issue as we don't claim to support npm)
something tries to bring in bootstrap@4

Maybe it will make more sense to minimize the bower dependencies to a bare minimum manually and only then use bower-away.

(Another reason to do that is that yarn actually treats these bower dependencies in much the same way as bundler does github branches - slowly :).)

~~(That said, still trying to use package overrides to achieve the quicker result :).)~~

himdel · 2018-01-30T17:32:47Z

Resurrecting ManageIQ/manageiq#12581 in smaller parts, hoping to reduce this to only packages which don't have an equivalent npm version.

Fryguy · 2018-02-13T20:46:55Z

@himdel I'm following your adventures in the other PRs...let me know when you want me to rebase this (unless you just want to take it over in a separate PR)

miq-bot · 2018-08-20T04:00:31Z

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!

miq-bot · 2018-09-18T09:53:05Z

This pull request is not mergeable. Please rebase and repush.

Fryguy · 2018-10-08T17:22:39Z

Closed via #4735

Fryguy added the technical debt label Oct 31, 2017

miq-bot added the wip label Oct 31, 2017

chessbyte requested a review from ohadlevy October 31, 2017 05:06

chessbyte added the developer label Oct 31, 2017

Fryguy force-pushed the bower-away branch from 08255bd to ad4d7bd Compare October 31, 2017 07:35

miq-bot added the unmergeable label Nov 30, 2017

Fryguy force-pushed the bower-away branch from ad4d7bd to 4d2a259 Compare December 4, 2017 22:07

miq-bot removed the unmergeable label Dec 4, 2017

martinpovolny assigned himdel Dec 5, 2017

martinpovolny requested a review from himdel December 5, 2017 07:57

miq-bot added the unmergeable label Dec 11, 2017

Remove bower setup for CI

9ed2cd4

Fryguy force-pushed the bower-away branch from 4d2a259 to 1e416a0 Compare January 9, 2018 22:53

PAUSED: Use git resume to continue working.

2eb0e34

Fryguy force-pushed the bower-away branch from 1e416a0 to 2eb0e34 Compare January 9, 2018 22:54

miq-bot removed the unmergeable label Jan 9, 2018

miq-bot added the unmergeable label Jan 29, 2018

himdel mentioned this pull request Jan 30, 2018

Bower to npm - make it possible to explicitly choose #3343

Merged

himdel mentioned this pull request Apr 9, 2018

bower to npm - remaining packages #3734

Closed

miq-bot closed this Aug 20, 2018

Fryguy reopened this Sep 17, 2018

Fryguy added the pinned label Sep 17, 2018

Fryguy closed this Oct 8, 2018

Fryguy deleted the bower-away branch October 12, 2018 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Remove bower via bower-away #2571

[WIP] Remove bower via bower-away #2571

Fryguy commented Oct 31, 2017 •

edited

Loading

ohadlevy commented Oct 31, 2017

himdel commented Oct 31, 2017

himdel commented Oct 31, 2017 •

edited

Loading

himdel commented Oct 31, 2017 •

edited

Loading

himdel commented Oct 31, 2017

himdel commented Oct 31, 2017

miq-bot commented Nov 30, 2017

miq-bot commented Dec 11, 2017

martinpovolny commented Dec 23, 2017

Fryguy commented Jan 9, 2018

Fryguy commented Jan 9, 2018 •

edited

Loading

miq-bot commented Jan 9, 2018

miq-bot commented Jan 29, 2018

himdel commented Jan 30, 2018 •

edited

Loading

himdel commented Jan 30, 2018

Fryguy commented Feb 13, 2018

miq-bot commented Aug 20, 2018

miq-bot commented Sep 18, 2018

Fryguy commented Oct 8, 2018

[WIP] Remove bower via bower-away #2571

[WIP] Remove bower via bower-away #2571

Conversation

Fryguy commented Oct 31, 2017 • edited Loading

ohadlevy commented Oct 31, 2017

himdel commented Oct 31, 2017

himdel commented Oct 31, 2017 • edited Loading

Keep:

Remove:

himdel commented Oct 31, 2017 • edited Loading

himdel commented Oct 31, 2017

himdel commented Oct 31, 2017

miq-bot commented Nov 30, 2017

miq-bot commented Dec 11, 2017

martinpovolny commented Dec 23, 2017

Fryguy commented Jan 9, 2018

Fryguy commented Jan 9, 2018 • edited Loading

miq-bot commented Jan 9, 2018

miq-bot commented Jan 29, 2018

himdel commented Jan 30, 2018 • edited Loading

himdel commented Jan 30, 2018

Fryguy commented Feb 13, 2018

miq-bot commented Aug 20, 2018

miq-bot commented Sep 18, 2018

Fryguy commented Oct 8, 2018

Fryguy commented Oct 31, 2017 •

edited

Loading

himdel commented Oct 31, 2017 •

edited

Loading

himdel commented Oct 31, 2017 •

edited

Loading

Fryguy commented Jan 9, 2018 •

edited

Loading

himdel commented Jan 30, 2018 •

edited

Loading