This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Use react-native-screens #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortalKastor
force-pushed
the
react-native-screens
branch
from
27d926a
to
7132b02
Compare
|
let's test this again next week. we have a usage of react-native-gesture-handler now (the graph). if you can't properly interact with the graph anymore with this lib, then it's a dead end. if there is no difference, we should be good. We might want to play with the react-native-gesture-handler buttons too before testing these, so maybe smart to first work on #208 . For the ReactFragmentActivity thing, I think it's not a blocker to get this in but we might want to Subscribe on software-mansion/react-native-screens#7 discussions to get it solved |
gre
approved these changes
Sep 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the bleeding edge react-native-screens to use native navigation containers which could bring sizable performance improvements (see https://www.youtube.com/watch?v=Z0Jl1KCWiag ).
Flagged as
HODLbecause:ReactFragmentActivityon Android, which has been deprecated (Note: usage of ReactFragmentActivity was supposed to be removed in RN 0.57 software-mansion/react-native-screens#7)react-native-gesture-handler(Question: does it work out of the box with react-native-gesture-handler? software-mansion/react-native-screens#9)