Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: does it work out of the box with react-native-gesture-handler? #9

Closed
lebedev opened this issue Sep 13, 2018 · 6 comments
Closed

Comments

@lebedev
Copy link

lebedev commented Sep 13, 2018

If I'm not mistaken, to make react-native-gesture-handler work with native navigation libraries (like wix's react-native-navigation), additional steps of setting it up are required. Does additional steps required if one uses react-native-screens with react-native-gesture-handler?

It would be great to have an answer to this question in README.

@kmagiera
Copy link
Member

hey @angly-cat that's a good point to mention how this library relates to react-native-navigation.

In short, it works just ok with react-native-navigation, that is you can use both ScreenContainer and Screens in RNN scenes. But most of the time this will not give you any benefits comparing to other "js only" navigation libraries. Since RNN uses native navigation components already (the approach is slightly different to what screens + react-navigation can do) the views that gets rendered in RNN scenes already get proper lifecycle management. One of a possible use cases where I see screens working along with RNN would be if you were to build screen pager component. Then you could render that inside RNN scene but pages lifecycle will then be controlled by ScreenContainer

Hope this answers your question.

PS:I'll keep this issue open to remind me to add that info to the README

@lebedev
Copy link
Author

lebedev commented Sep 18, 2018

Hi, @kmagiera. Thanks for answering. While it'll be great to have an overview how this library relates to RNN, my question actually was about your other library react-native-gesture-handler. I use RNGH extensively in my app, so I wonder if additional steps are required to integrate RNGH with this library or if they work alongside each other out of the box.

@brentvatne
Copy link
Contributor

they will work with each other out of the box

@lebedev
Copy link
Author

lebedev commented Sep 19, 2018

Ok, thanks for answering, @brentvatne!

@lebedev lebedev closed this as completed Sep 19, 2018
@lebedev
Copy link
Author

lebedev commented Sep 19, 2018

I just remembered @kmagiera wanting this issue to stay opened as a reminder. Sorry for closing it prematurely.

@lebedev lebedev reopened this Sep 19, 2018
@kmagiera
Copy link
Member

Updated the readme, thanks @angly-cat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants