Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce usage analytics #379

Merged
merged 1 commit into from
May 13, 2021
Merged

feat: introduce usage analytics #379

merged 1 commit into from
May 13, 2021

Conversation

hbagdi
Copy link
Member

@hbagdi hbagdi commented May 13, 2021

Analytics were temporarily removed as we sent them to a third-party
server.
With this new implementation, these are being sent to Kong Inc directly.

Furthermore, to alleviate concerns raised
in #242, we are now providing a flag on
the root-level, in addition to DECK_ANALYTICS environment variable to
tweak the setting.

Analytics were temporarily removed as we sent them to a third-party
server.
With this new implementation, these are being sent to Kong Inc directly.

Furthermore, to alleviate concerns raised
in #242, we are now providing a flag on
the root-level, in addition to DECK_ANALYTICS environment variable to
tweak the setting.
@hbagdi hbagdi requested a review from a team as a code owner May 13, 2021 18:18
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #379 (82fd70b) into main (8fa14fe) will decrease coverage by 0.59%.
The diff coverage is 5.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   54.19%   53.59%   -0.60%     
==========================================
  Files          61       62       +1     
  Lines        4971     5034      +63     
==========================================
+ Hits         2694     2698       +4     
- Misses       1978     2037      +59     
  Partials      299      299              
Impacted Files Coverage Δ
cmd/common.go 0.00% <0.00%> (ø)
cmd/dump.go 25.26% <0.00%> (-1.12%) ⬇️
cmd/konnect_diff.go 73.68% <0.00%> (-4.10%) ⬇️
cmd/konnect_dump.go 26.53% <0.00%> (-0.56%) ⬇️
cmd/konnect_ping.go 6.66% <0.00%> (-0.48%) ⬇️
cmd/konnect_sync.go 66.66% <0.00%> (-4.77%) ⬇️
cmd/ping.go 33.33% <0.00%> (-2.39%) ⬇️
cmd/reset.go 26.15% <0.00%> (-1.72%) ⬇️
cmd/validate.go 22.58% <0.00%> (-0.76%) ⬇️
utils/analytics.go 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa14fe...82fd70b. Read the comment docs.

@hbagdi hbagdi merged commit 7d3c9fa into main May 13, 2021
@hbagdi hbagdi deleted the refactor/analytics branch May 13, 2021 20:40
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
Analytics were temporarily removed as we sent them to a third-party
server.
With this new implementation, these are being sent to Kong Inc directly.

Furthermore, to alleviate concerns raised
in #242, we are now providing a flag on
the root-level, in addition to DECK_ANALYTICS environment variable to
tweak the setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants