Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop tracking your users #242

Closed
wants to merge 1 commit into from

Conversation

marcelometal
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2020

CLA assistant check
All committers have signed the CLA.

@hbagdi
Copy link
Member

hbagdi commented Dec 7, 2020

Hey @marcelometal,

Thanks for opening the PR. I completely understand your concern here.
We are not tracking users using our anonymous analytics. It is strictly meant to track rate of adoption of decK and it's various versions. We intentionally do not include any sort of identifying information in the data that is sent back.

If you would like, you can disable the anonymized reports by setting the environment variable DECK_ANALYTICS=off.

@hbagdi hbagdi closed this Dec 7, 2020
@marcelometal
Copy link
Author

Hi @hbagdi ,

Since you don't intend to remove this part of the code, could you please add a note in README.md to inform all users about deck analytics and how to disabled it?

@hbagdi
Copy link
Member

hbagdi commented Dec 8, 2020

We call it out in our documentation: https://docs.konghq.com/deck/commands/#analytics.
README.md is meant to provide an introduction to the project and I'm a little hesitant to talk about this detail in there. Is that acceptable?

@marcelometal
Copy link
Author

marcelometal commented Dec 9, 2020

Sorry, but IMHO no, that's not enough...

For me, transparency is one of the most compelling benefits of open source software. So, there are no surprises and no hidden functions...

For example, Debian Popularity Contest (popcon). The default value is "no" and it's a personal choice.

Features section in README has practically the same content of Commands Section in Kong`s website. So, please add a small paragraph about deck analytics in README. It will increases credibility too.

image

@hbagdi
Copy link
Member

hbagdi commented Dec 9, 2020

So, there are no surprises and no hidden functions...

I understand where you are coming from here but please note that we have absolutely no intentions of hiding any feature.

For me, transparency is one of the most compelling benefits of open source software.

I completely agree. Transparency is one of the reasons I wake up every day to contribute to open-source software. In this specific case, we keep the behavior configurable and document it. If we didn't document this and forced you to share anonymized data, then anyone questioning our transparency could have had a reasonable case. This is not the case here and to our knowledge, we are doing our best to communicate this.

So, please add a small paragraph about deck analytics in README. It will increases credibility too.

I'm sorry but I'm not yet convinced that the README is the right place for such a detail. Our purpose of having a README is to provide an introduction and pointers to get started using this project.

@marcelometal
Copy link
Author

I understand where you are coming from here but please note that we have absolutely no intentions of hiding any feature.

Yes, you are hiding this "feature" and tracking your users without consent.

This kind of information should be close to the source/binary (README or --help command)

@scorphus
Copy link

scorphus commented Jan 24, 2021

I totally agree with @marcelometal here. This kind of "feature" should be opt-in instead of opt-out. No question about it.

@marcelometal
Copy link
Author

marcelometal commented Apr 18, 2021

Thank you #275 and #301

hbagdi added a commit that referenced this pull request May 13, 2021
Analytics were temporarily removed as we sent them to a third-party
server.
With this new implementation, these are being sent to Kong Inc directly.

Furthermore, to alleviate concerns raised
in #242, we are now providing a flag on
the root-level, in addition to DECK_ANALYTICS environment variable to
tweak the setting.
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
Analytics were temporarily removed as we sent them to a third-party
server.
With this new implementation, these are being sent to Kong Inc directly.

Furthermore, to alleviate concerns raised
in #242, we are now providing a flag on
the root-level, in addition to DECK_ANALYTICS environment variable to
tweak the setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants