Fix selection of table sort order #10250
Conversation
Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/jabref/logic/bibtex/comparator/MetaDataDiff.java
Outdated
Show resolved
Hide resolved
|
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
|
There are a lot of architectural changes and especially the call to getTableSaveOrder in JabrefPreferences was on purpose private, since it is a low level call to the backing store as far as I remember. Also the changes to persistentVisualState are suspicious to me. I will take a look at it tomorrow and will try to make suggestions to improve it. |
I am aware of that. At some place, there needs to be a mapping from the table sort order (UI) to
There should be no "doing" in a constructor, because a constructor is for initializing the class. "Doings" should be at methods. This was done at with that change. -- I know that the class at hand is a kind of helper class, because it's constructed once only and has not any further usage. Maybe, the whole thing should be refactored to a static method. Will do. |
src/test/java/org/jabref/logic/bibtex/comparator/FieldComparatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/bibtex/comparator/FieldComparatorTest.java
Outdated
Show resolved
Hide resolved
…fix-table-sort-order # Conflicts: # src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java # src/main/java/org/jabref/logic/autosaveandbackup/BackupManager.java # src/main/java/org/jabref/preferences/PreferencesService.java
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
* upstream/main: (737 commits) Use OpenRewrite UseStringReplace (#10299) Add ReplaceStringBuilderWithString (#10302) Apply ShortenFullyQualifiedTypeReferences (#10301) Apply StaticMethodNotFinal (#10300) Apply exit early pattern (#10297) Avoid GH_TOKEN_UPDATE_GRADLE_WRAPPER at refresh-csl-subtrees Update snapcraft.yaml Fix exception when opening preferences (#10294) gnome-42-2204 use gnome 4.2 Use gnome Update base 22 Add method for detecting journal abbrev delimiter (#10281) Update bug_report.yml Fix selection of table sort order (#10250) Fix mixup with YAML tags (#10287) More guards for upload (#10282) Reduced calls to Globals.prefs and Globals.entryTypesManager (#10177) Update jmh plugin (#10279) Add computer science to protected terms (#10222) ... # Conflicts: # build.gradle # src/main/java/module-info.java # src/main/java/org/jabref/cli/Launcher.java # src/main/java/org/jabref/preferences/JabRefPreferences.java # src/main/resources/tinylog.properties
…ustStore * upstream/main: (295 commits) Use OpenRewrite UseStringReplace (#10299) Add ReplaceStringBuilderWithString (#10302) Apply ShortenFullyQualifiedTypeReferences (#10301) Apply StaticMethodNotFinal (#10300) Apply exit early pattern (#10297) Avoid GH_TOKEN_UPDATE_GRADLE_WRAPPER at refresh-csl-subtrees Update snapcraft.yaml Fix exception when opening preferences (#10294) gnome-42-2204 use gnome 4.2 Use gnome Update base 22 Add method for detecting journal abbrev delimiter (#10281) Update bug_report.yml Fix selection of table sort order (#10250) Fix mixup with YAML tags (#10287) More guards for upload (#10282) Reduced calls to Globals.prefs and Globals.entryTypesManager (#10177) Update jmh plugin (#10279) Add computer science to protected terms (#10222) ...
Fixes #9869
We also have meta data changes upon save. I added a quick output of these changes. This is far from end user friendly, but better than outputting nothing.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)