Reduced calls to Globals.prefs and Globals.entryTypesManager #10177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixtus
added
type: code-quality
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/org/jabref/logic/exporter/XmpPdfExporterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/exporter/XmpPdfExporterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/exporter/XmpPdfExporterTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/org/jabref/gui/JabRefGUI.java # src/main/java/org/jabref/gui/preview/PreviewPanel.java
…duced_globals_calls
|
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
approved these changes
Sep 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Siedlerchr
added a commit
that referenced
this pull request
Sep 3, 2023
* upstream/main: (737 commits) Use OpenRewrite UseStringReplace (#10299) Add ReplaceStringBuilderWithString (#10302) Apply ShortenFullyQualifiedTypeReferences (#10301) Apply StaticMethodNotFinal (#10300) Apply exit early pattern (#10297) Avoid GH_TOKEN_UPDATE_GRADLE_WRAPPER at refresh-csl-subtrees Update snapcraft.yaml Fix exception when opening preferences (#10294) gnome-42-2204 use gnome 4.2 Use gnome Update base 22 Add method for detecting journal abbrev delimiter (#10281) Update bug_report.yml Fix selection of table sort order (#10250) Fix mixup with YAML tags (#10287) More guards for upload (#10282) Reduced calls to Globals.prefs and Globals.entryTypesManager (#10177) Update jmh plugin (#10279) Add computer science to protected terms (#10222) ... # Conflicts: # build.gradle # src/main/java/module-info.java # src/main/java/org/jabref/cli/Launcher.java # src/main/java/org/jabref/preferences/JabRefPreferences.java # src/main/resources/tinylog.properties
Siedlerchr
added a commit
that referenced
this pull request
Sep 4, 2023
…ustStore * upstream/main: (295 commits) Use OpenRewrite UseStringReplace (#10299) Add ReplaceStringBuilderWithString (#10302) Apply ShortenFullyQualifiedTypeReferences (#10301) Apply StaticMethodNotFinal (#10300) Apply exit early pattern (#10297) Avoid GH_TOKEN_UPDATE_GRADLE_WRAPPER at refresh-csl-subtrees Update snapcraft.yaml Fix exception when opening preferences (#10294) gnome-42-2204 use gnome 4.2 Use gnome Update base 22 Add method for detecting journal abbrev delimiter (#10281) Update bug_report.yml Fix selection of table sort order (#10250) Fix mixup with YAML tags (#10287) More guards for upload (#10282) Reduced calls to Globals.prefs and Globals.entryTypesManager (#10177) Update jmh plugin (#10279) Add computer science to protected terms (#10222) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self explaining. In preparation for JabCon cleaning up dependencies to prefs.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)