Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay - closeOnEsc docs #2085

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Overlay - closeOnEsc docs #2085

merged 4 commits into from
Jul 20, 2020

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Jul 14, 2020

Related to IgniteUI/igniteui-angular#7697

Checklist:

  • check topic's TOC/menu and paragraph headings
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

wnvko
wnvko previously approved these changes Jul 15, 2020
@Lipata Lipata force-pushed the bpenkov/overlay-close-on-esc branch from 84a2325 to 5454f38 Compare July 17, 2020 14:06
@Lipata Lipata merged commit 9e69789 into vNext Jul 20, 2020
@Lipata Lipata deleted the bpenkov/overlay-close-on-esc branch July 20, 2020 13:48
Lipata added a commit that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants