Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not close modal overlay on ESC key press #7697

Closed
wnvko opened this issue Jun 29, 2020 · 1 comment · Fixed by #7741 or #7793
Closed

Do not close modal overlay on ESC key press #7697

wnvko opened this issue Jun 29, 2020 · 1 comment · Fixed by #7741 or #7793
Assignees
@Lipata @jackofdiamond5
Labels
🧨 severity: medium overlay 🧰 feature-request version: 10.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@wnvko
Copy link
Contributor

wnvko commented Jun 29, 2020

Is your feature request related to a problem? Please describe.

There is no way to stop closing of IgxDialog on ESC key press. This is valid also for all components using IgxOverlay in modal mode.

Describe the solution you'd like

Allow configuration of the overlay allowing to discard ESC key press. This could be added in OverlaySettings. We have now closeOnOutsideClick property. There should be and something like closeOnEsc.
@Lipata Lipata mentioned this issue Jun 29, 2020
Closed
@jackofdiamond5 jackofdiamond5 self-assigned this Jun 30, 2020
@jackofdiamond5 jackofdiamond5 added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jun 30, 2020
@jackofdiamond5 jackofdiamond5 mentioned this issue Jul 3, 2020
Merged
14 tasks
@jackofdiamond5 jackofdiamond5 added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 3, 2020
@Lipata Lipata reopened this Jul 13, 2020
@jackofdiamond5
Copy link
Member

We've reopened this issue because we needed to define a way for the overlay to close on Esc keypress when it is not modal. Additionally, we had to discuss how we want to handle scenarios with stacked overlays. We came to an agreement that the stacked overlays should be closed from last to first. Also, it should not matter if the overlay is modal or not - if the settings have a closeOnEsc property set to true, it is considered a candidate for closing and will be closed when the key is pressed.

This was referenced Jul 14, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@jackofdiamond5 jackofdiamond5

Labels
🧨 severity: medium overlay 🧰 feature-request version: 10.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
3 participants
@Lipata @wnvko @jackofdiamond5