IgxDatePicker refactoring #8939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackofdiamond5
force-pushed
the
pickers-refactoring
branch
from
7e2c752
to
8e2ef17
Compare
14 tasks
jackofdiamond5
added
refactoring
❌ status: awaiting-test
jackofdiamond5
force-pushed
the
bpenkov/date-picker-refactoring
branch
2 times, most recently
from
b4edbad
to
625606b
Compare
damyanpetev
reviewed
Apr 2, 2021
projects/igniteui-angular/src/lib/date-picker/date-picker.common.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.html
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.html
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.html
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.html
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.module.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.module.ts
Outdated
Show resolved
Hide resolved
damyanpetev
reviewed
Apr 2, 2021
| * when onValidationFailed event is fired. | ||
| */ | ||
| export interface IDatePickerValidationFailedEventArgs extends IBaseEventArgs { | ||
| owner: IgxDatePickerComponent; |
There was a problem hiding this comment.
Hmm this seems like a good candidate to make base args generic, so we don't need to override the prop to type it correctly.
projects/igniteui-angular/src/lib/date-picker/date-picker.component.html
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
Outdated
Show resolved
Hide resolved
damyanpetev
reviewed
Apr 2, 2021
projects/igniteui-angular/src/lib/date-picker/date-picker.component.html
Outdated
Show resolved
Hide resolved
damyanpetev
reviewed
Apr 5, 2021
projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
Outdated
Show resolved
Hide resolved
damyanpetev
reviewed
Apr 5, 2021
projects/igniteui-angular/src/lib/date-common/picker-base.directive.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.common.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.ts
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/filtering/base/grid-filtering-row.component.html
Show resolved
Hide resolved
…tive - clean and update public api
jackofdiamond5
force-pushed
the
bpenkov/date-picker-refactoring
branch
from
10f73f0
to
905edfc
Compare
damyanpetev
reviewed
Apr 7, 2021
…id range - set outlet on open
jackofdiamond5
force-pushed
the
bpenkov/date-picker-refactoring
branch
from
2ad9b6a
to
7f767f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6483
Closes #7199
Closes #7169
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)