Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor igxDatePicker, igxTimePicker interfaces and define a common one #7199

Closed
5 tasks done
Lipata opened this issue Apr 23, 2020 · 1 comment · Fixed by #9160
Closed
5 tasks done

Refactor igxDatePicker, igxTimePicker interfaces and define a common one #7199

Lipata opened this issue Apr 23, 2020 · 1 comment · Fixed by #9160
Assignees
Labels
📈 enhancement 📅 date-picker 📅 date-range-picker 📅 date-time-editor program: igniteui project management version: 9.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Lipata
Copy link
Member

Lipata commented Apr 23, 2020

igxDatePicker implements the following interface and igxTimePikcer implements this one. After the IgxDateTimeEditorDirective is created, these interfaces should be revised. There are properties/methods/events (mode, calendar events) that are common for both, as well for the IgxRangeDatePickerComponent, so they should be extracted to a separate interface. Implements IToggleInterface (the latter should be extended and synced within the product)

  • Define a common abstract class for the IgxDatePickerComponent, IgxTimePickerComponent and IgxDateRangePickerComponent with base functionality (and possible additional extension for each component)
  • Update specification of IgxDatePickerComponent
  • Update specification of IgxTimePickerComponent

  • Refactoring of IgxDatePickerComponent
  • Refactoring of IgxTimePickerComponent

IgxDateTimeEditorDirective needs to be used as the input for all pickers.

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Aug 10, 2020
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Aug 10, 2020
@Lipata Lipata assigned jackofdiamond5 and unassigned Lipata Oct 1, 2020
This was referenced Jan 8, 2021
@Lipata Lipata added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jan 11, 2021
@radomirchev radomirchev added the program: igniteui project management label Jan 19, 2021
@Lipata Lipata added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 12, 2021
@Lipata Lipata mentioned this issue Mar 12, 2021
14 tasks
@Lipata Lipata mentioned this issue Apr 14, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 enhancement 📅 date-picker 📅 date-range-picker 📅 date-time-editor program: igniteui project management version: 9.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants