-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python@3.10: make keg-only #86469
python@3.10: make keg-only #86469
Conversation
This should involve a revision bump or existing installations won't be made keg only. |
does that imply this can't be a |
Revision bump means new bottles so it can’t be syntax-only, sorry.
It’s important we migrate users or they will face conflicts if they attempt to install python@3.10.
|
|
Other adjustments to make, if I haven't missed anything: - # post_install happens after link
- %W[pip3 wheel3 pip#{version.major_minor}].each do |e|
- (HOMEBREW_PREFIX/"bin").install_symlink bin/e
- end
- def caveats
<<~EOS
Python has been installed as
- #{HOMEBREW_PREFIX}/bin/python3
+ #{opt_bin}/python3
Unversioned symlinks `python`, `python-config`, `pip` etc. pointing to
`python3`, `python3-config`, `pip3` etc., respectively, have been installed into
#{opt_libexec}/bin
You can install Python packages with
- pip3 install <package>
+ #{opt_bin}/pip3 install <package> |
happy to fix those, but CI will take several days correct? I was assuming we needed a quick fix, because we currently have if that's the case and I'm not misunderstanding, then perhaps we should first make |
If we want something quick we could add |
seems the last python migration went like this:
if we're following that again, then we just missed making |
Sounds good! |
cce7031
to
8208568
Compare
8208568
to
ee55f83
Compare
Well, one day maybe - not several. Though I'm also fine with the 3.10 keg only approach for now. |
We also need to do Also, more changes might be needed here -- IIRC what we do with At least, I think that's what I found when I tried backporting the changes to |
Installing to |
I think |
A quick test in the CI is to ask it to print the contents of |
0f2a7db
to
85fc229
Compare
seems neither |
85fc229
to
dff2c9c
Compare
dff2c9c
to
26b543c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @branchvincent!
@@ -23,6 +24,8 @@ class PythonAT310 < Formula | |||
# build packages later. Xcode-only systems need different flags. | |||
pour_bottle? only_if: :clt_installed | |||
|
|||
keg_only :versioned_formula | |||
|
|||
depends_on "pkg-config" => :build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, does this have OpenSSL 1.1 in its dep tree other than through here? If so we should use OpenSSL 3.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use OpenSSL 3.0 until it or 1.1 is keg only, or we're just going to reintroduce the problem #86520 is having.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also that person was probably right in saying we should avoid anything too important while that old macOS build issue is still a thing.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Closes #86520
#84626 (comment)
cc: @carlocab