Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.10.0 #84626

Closed
wants to merge 4 commits into from
Closed

python 3.10.0 #84626

wants to merge 4 commits into from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Sep 3, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

First try with Python 3.10.0 release candidate 1. https://www.python.org/downloads/release/python-3100rc1/

Audit currently fails with

  * Versioned formulae in homebrew/core should use `keg_only :versioned_formula`
  * Stable version URLs should not contain rc1

Note that, compared to python@3.9, I removed the decimal diff since I couldn't find the one for for Python 3.10.

Release candidate 2 is scheduled for Monday, 2021-09-06.

@Moisan Moisan added do not merge pre-release Artifact is pre-release CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 3, 2021
@BrewTestBot BrewTestBot added legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core labels Sep 3, 2021
@branchvincent
Copy link
Member

i believe both audits can be ignored by updating versioned_keg_only_allowlist and unstable_allowlist

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 4, 2021
@cho-m
Copy link
Member

cho-m commented Sep 4, 2021

Looks like release candidate successfully builds, but CI probably won't find any dependents due to versioned depends_on "python@3.9" (~582 formulae).

@iMichka
Copy link
Member

iMichka commented Sep 4, 2021

Yes. If we want to test this correctly, we need to Rev bump all these 582 formulae and update the Python 3.9 dependency to 3.10. In 582 separate commits.

@Moisan
Copy link
Member Author

Moisan commented Sep 6, 2021

👍 I'll first try all formulae that are in brew uses python@3.9 and we'll see how it goes.

@BrewTestBot BrewTestBot added python Python use is a significant feature of the PR or issue and removed automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Sep 6, 2021
@cho-m
Copy link
Member

cho-m commented Sep 6, 2021

Sounds good as remaining will require CI-build-dependents-from-source to correctly test.

May need to use Self-Hosted Linux given how long Python 3.9.7 CI took.

EDIT: Looks like a bit more find-replace is required as some formulae have multiple version references

@Moisan
Copy link
Member Author

Moisan commented Sep 8, 2021

A few issues that I spotted based on the current ARM failures (138 fails):

@branchvincent
Copy link
Member

sphinx-doc fix landed with #85095

@Moisan Moisan force-pushed the python310 branch 2 times, most recently from 2eed48d to def3d16 Compare September 17, 2021 23:42
@Moisan
Copy link
Member Author

Moisan commented Sep 17, 2021

I rebased on master and updated to Python 3.10rc2.

@branchvincent
Copy link
Member

sip just released 3.10 support, landed in #86393

@Moisan
Copy link
Member Author

Moisan commented Oct 4, 2021

Python 3.10 should officially be released today. My plan is to follow the previous python@3.9 migration pattern:

  • Merge python@3.10 and python-tk@3.10 within this PR
  • Open individual PR for independent formulae first: depend on python@3.9 only directly and have no reverse dependencies. I can probably write a script to do that automatically.
  • Migrate other formulae

@cclauss
Copy link
Contributor

cclauss commented Oct 4, 2021

Python 3.10.0 source is now available at https://www.python.org/ftp/python/3.10.0/

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 4, 2021
@Moisan Moisan removed do not merge pre-release Artifact is pre-release labels Oct 4, 2021
branchvincent
branchvincent previously approved these changes Oct 5, 2021
Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match statement, here we come!

@BrewTestBot
Copy link
Member

:shipit: @branchvincent has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @branchvincent bottle publish failed.

Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, forgot --no-autosquash

@BrewTestBot
Copy link
Member

:shipit: @branchvincent has triggered a merge.

@carlocab
Copy link
Member

carlocab commented Oct 5, 2021

Have we made python@3.9 keg-only?

@branchvincent
Copy link
Member

i guess we need to migrate the aliases as well as make python@3.9 key-only. let me do that

@branchvincent branchvincent mentioned this pull request Oct 5, 2021
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. legacy Relates to a versioned @ formula outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.10-migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants