Update Translate samples, with some minor tweaks to Language samples. #255

jmdobry · 2016-11-16T00:13:55Z

No description provided.

ace-n · 2016-11-16T01:14:33Z

It looks like there's a PubSub test that's failing pretty deterministically on CircleCI - mind submitting a (separate?) PR for that?

jmdobry · 2016-11-16T17:34:28Z

Yeah, I'll go figure that one out.

puneith · 2016-11-17T19:05:44Z

language/README.md

-  node analyze sentimentOfText "President Obama is speaking at
+  node analyze.js sentiment-text "President Obama is speaking
+  at the White House."
+  node analyze.js sentiment-file my-bucket file.txt


Make it clear that its a gcs file gs://bucket/foo/ I have seen people give s3 files to our sample code :)

puneith · 2016-11-17T19:06:18Z

language/README.md

+  node analyze.js sentiment-file my-bucket file.txt
+  node analyze.js entities-text "President Obama is speaking
+  at the White House."
+  node analyze.js entities-file my-bucket file.txt


I guess similar comment wherever you have my-bucket

puneith · 2016-11-17T19:07:45Z

language/README.md

-  syntaxOfText <text>                  Detect the syntax of a block of text.
-  syntaxInFile <bucket> <filename>     Detect the syntax of text in a GCS file.
+  sentiment-text <text>               Detects sentiment of a string.
+  sentiment-file <bucket> <filename>  Detects the sentiment in a file in Cloud Storage.


Its not a specific group of sentiments here, so no "the" required. Simply "Detects sentiment in a file..."

puneith · 2016-11-17T19:09:12Z

language/analyze.js

+  )
+  .command(
+    `sentiment-file <bucket> <filename>`,
+    `Detects the sentiment in a file in Cloud Storage.`,


Google Cloud Storage

puneith · 2016-11-17T19:10:00Z

language/analyze.js

+    `sentiment-file <bucket> <filename>`,
+    `Detects the sentiment in a file in Cloud Storage.`,
+    {},
+    (opts) => analyzeSentimentInFile(opts.bucket, opts.filename)


May be call it gcs_bucket here and everywhere to make it clear.

puneith · 2016-11-17T20:27:57Z

language/analyze.js

+    `sentiment-file <bucket> <filename>`,
+    `Detects sentiment in a file in Google Cloud Storage.`,
+    {},
+    (opts) => analyzeSentimentInFile(opts.bucket, opts.filename)


I am not seeing any output from $ node analyze sentiment-text "President Obama is speaking" for example.

See #255 (comment)

puneith · 2016-11-17T20:28:45Z

language/analyze.js

@@ -111,10 +117,12 @@ function analyzeEntitiesInFile (bucketName, fileName) {
  return document.detectEntities()


Same is for entities. No entities printed on console.

See #255 (comment)

puneith · 2016-11-17T22:23:09Z

language/README.md


 ```
 Commands:
-  sentimentOfText <text>               Detect the sentiment of a block of text.


The program doesn't throw an error if GOOGLE_APPLICATION_CREDENTIALS is not set. It silently swallows it and return nothing. We should fix this behavior.

It's not the fault of the program, it's the fault of google-cloud-node. There's nothing I can fix about that in this PR.

True. I realized that now. But can we file an issue for those guys.

ace-n

LGTM, other than my comments.

ace-n · 2016-11-17T23:04:58Z

translate/package.json

@@ -5,16 +5,12 @@
  "license": "Apache Version 2.0",
  "author": "Google Inc.",
  "scripts": {
-    "test": "mocha -R spec --require intelli-espower-loader ../test/_setup.js test/*.test.js",
-    "system-test": "mocha -R spec --require intelli-espower-loader ../system-test/_setup.js system-test/*.test.js"
+    "test": "cd ..; npm run st -- translate/system-test/*.test.js"


Nit: I'm not a fan of cding in tests, especially if this affects the user's current directory.

This does not affect the user's current directory, it just assigns a "current working directory" to the npm script that's being executed.

ace-n · 2016-11-17T23:13:35Z

translate/system-test/translate.test.js

+    const output = run(`${cmd} detect "${text}" "${text2}"`, cwd);
+    return translate.detect([text, text2])
+      .then((results) => {
+        const expected = `Detections:\n${text} => ${results[0][0].language}\n${text2} => ${results[0][1].language}`;


It looks like we're relying on the Translate API to correctly detect language here. Is that OK, or should we specify language as a constant? (i.e. "en")

It's fine to rely on the Translate API. This way we're just testing our code, and not the Translate API itself (not our responsibility).

ace-n · 2016-11-17T23:27:32Z

translate/translate.js

+    .then((results) => {
+      let detections = results[0];
+
+      if (!Array.isArray(detections)) {


Nit: I know it's silly, but there's a library for that. 😛

(If you decide to use it, please fix this throughout your PR.)

I don't usually use libraries for things that, as you say, are so silly. And, I avoid importing libraries into our samples in general (except for the Google Cloud Client libraries and Node.js core modules). We don't want to obscure and abstract, we want to be painfully clear.

ace-n · 2016-11-17T23:32:35Z

translate/translate.js

+    {},
+    (opts) => {
+      if (opts.target) {
+        listLanguagesWithTarget(opts.target);


Wishful thinking: listLanguages goes away, and listLanguagesWithTarget just uses en as a default.

I'm tempted to decline, as these are two separate examples in the docs.

ace-n

LGTM - provided @puneith is happy, this should be good to merge.

…#255)

…#255)

* feat: initial release of cloud build library (#2) * feat(docs): add listBuildTriggers sample to README (#5) * feat: moves library to TypeScript code generation (#10) * chore: release 1.0.0 (#3) * chore: release 1.1.0 (#20) * chore: update license headers * chore: release 1.2.0 (#25) * chore: release 1.3.0 (#33) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore(deps): update dependency c8 to v7 (#38) * refactor: use explicit mocha imports (#40) * chore(deps): update dependency mocha to v7 (#43) * chore: release 1.3.1 * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore: release 1.3.2 (#49) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore: release 1.3.3 (#59) * chore: release 1.4.0 (#63) * chore: release 1.5.0 (#67) * chore(deps): update dependency mocha to v8 (#122) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://github.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#801--2020-06-10) [Compare Source](https://github.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### 🐛 Fixes - [#4328](https://github.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://github.com/boneskull)) ### [`v8.0.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#800--2020-06-10) [Compare Source](https://github.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@giltayar**](https://github.com/giltayar) and [**@nicojs**](https://github.com/nicojs) to the maintenance team! #### 💥 Breaking Changes - [#4164](https://github.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@UlisesGascon**](https://github.com/UlisesGascon)) - [#4175](https://github.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@juergba**](https://github.com/juergba)) ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#4260](https://github.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@craigtaub**](https://github.com/craigtaub)) ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#4315](https://github.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@juergba**](https://github.com/juergba)) ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#4309](https://github.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@juergba**](https://github.com/juergba)) - [#4282](https://github.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@arvidOtt**](https://github.com/arvidOtt)) - [#4223](https://github.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@juergba**](https://github.com/juergba)) - [#4178](https://github.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@wnghdcjfe**](https://github.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### 🎉 Enhancements - [#4245](https://github.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@boneskull**](https://github.com/boneskull)) ❗ See also [#4244](https://github.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#4304](https://github.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@JacobLey**](https://github.com/JacobLey)) - [#4299](https://github.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@giltayar**](https://github.com/giltayar)) #### 📖 Documentation - [#4246](https://github.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@boneskull**](https://github.com/boneskull)) #### 🐛 Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-cloudbuild). * chore: release 2.0.0 (#92) :robot: I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://github.com/googleapis/nodejs-cloudbuild/compare/v1.5.0...v2.0.0) (2020-06-11) ### ⚠ BREAKING CHANGES * The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM. ### Features * add time-to-live in a queue for builds ([04e3387](https://github.com/googleapis/nodejs-cloudbuild/commit/04e3387af33a7ab39eb0c4df47ce08026507b499)) * check status of long running operation by its name ([#114](https://github.com/googleapis/nodejs-cloudbuild/issues/114)) ([7b50a74](https://github.com/googleapis/nodejs-cloudbuild/commit/7b50a74c098e782393f92140a37e3bd26f45e77d)) * drop node8 support, support for async iterators ([#91](https://github.com/googleapis/nodejs-cloudbuild/issues/91)) ([74a195d](https://github.com/googleapis/nodejs-cloudbuild/commit/74a195d5cdf63dab1ac3d0d52ef42e1254ab3a2e)) * improve support for x-goog-request-params ([#111](https://github.com/googleapis/nodejs-cloudbuild/issues/111)) ([e08d640](https://github.com/googleapis/nodejs-cloudbuild/commit/e08d64017e059c911ebe55055c26a0ab76481d86)) * move ts target to es2018 from es2016 ([#121](https://github.com/googleapis/nodejs-cloudbuild/issues/121)) ([59c5477](https://github.com/googleapis/nodejs-cloudbuild/commit/59c547744519ef9e8d073ea3ecdb81248176a71a)) ### Bug Fixes * remove eslint, update gax, fix generated protos, run the generator ([#100](https://github.com/googleapis/nodejs-cloudbuild/issues/100)) ([aafb9cc](https://github.com/googleapis/nodejs-cloudbuild/commit/aafb9cc7745b4d5d6dce58f17763f76379af733f)) * synth.py clean up for multiple version ([#115](https://github.com/googleapis/nodejs-cloudbuild/issues/115)) ([aa7d99b](https://github.com/googleapis/nodejs-cloudbuild/commit/aa7d99b9c02267808cac07f7691f5ce62f06ca14)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.0.1 (#126) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.0.2 (#133) :robot: I have created a release \*beep\* \*boop\* --- ### [2.0.2](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.0.1...v2.0.2) (2020-07-09) ### Bug Fixes * typeo in nodejs .gitattribute ([#132](https://github.com/googleapis/nodejs-cloudbuild/issues/132)) ([80b5bd9](https://github.com/googleapis/nodejs-cloudbuild/commit/80b5bd963aa43e5a47da9e6d0e2ffbf0cde7feef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.0.3 (#143) * chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.0.4 (#179) :robot: I have created a release \*beep\* \*boop\* --- ### [2.0.4](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.0.3...v2.0.4) (2020-11-03) ### ⚠ BREAKING CHANGES * The WorkerPool API in the v1 surface has been long deprecated, so it has been deleted from the v1 surface. Alpha WorkerPool customers who want to call the WorkerPool API can use gcloud. ### Features * updated third_party Cloud Build clients with new Build message, fix: revert removal of WorkerPool API ([#166](https://github.com/googleapis/nodejs-cloudbuild/issues/166)) ([b8d7a39](https://github.com/googleapis/nodejs-cloudbuild/commit/b8d7a395bbcc2f6ff83b798ef678e2f27395802d)) ### Bug Fixes * revert removal of WorkerPool API ([#178](https://github.com/googleapis/nodejs-cloudbuild/issues/178)) ([07400cb](https://github.com/googleapis/nodejs-cloudbuild/commit/07400cbcb05808762ab3c56c5827607cdefd43c0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.0.5 (#182) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.0.6 (#186) :robot: I have created a release \*beep\* \*boop\* --- ### [2.0.6](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.0.5...v2.0.6) (2020-11-25) ### Bug Fixes * check for fetch on window ([#185](https://github.com/googleapis/nodejs-cloudbuild/issues/185)) ([115de71](https://github.com/googleapis/nodejs-cloudbuild/commit/115de7141262c119113759aee5ddc141d129b55d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.1.0 (#205) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.0 (#213) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com> * chore: release 2.2.1 (#220) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.2 (#227) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.3 (#232) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.4 (#242) :robot: I have created a release \*beep\* \*boop\* --- ### [2.2.4](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.2.3...v2.2.4) (2021-06-24) ### Bug Fixes * make request optional in all cases ([#241](https://github.com/googleapis/nodejs-cloudbuild/issues/241)) ([c96003a](https://github.com/googleapis/nodejs-cloudbuild/commit/c96003a4897d3f7c8181a56c273b842a4dcdfbf7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.2.5 (#247) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.6 (#250) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.7 (#252) :robot: I have created a release \*beep\* \*boop\* --- ### [2.2.7](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.2.6...v2.2.7) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#251](https://github.com/googleapis/nodejs-cloudbuild/issues/251)) ([7bc5f7f](https://github.com/googleapis/nodejs-cloudbuild/commit/7bc5f7ff6c1485baaf1444a608d8ebb88ad20cfe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.3.0 (#263) :robot: I have created a release \*beep\* \*boop\* --- ## [2.3.0](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.2.7...v2.3.0) (2021-08-05) ### ⚠ BREAKING CHANGES * * feat: add a WorkerPools API ### Features * add a WorkerPools API ([#254](https://github.com/googleapis/nodejs-cloudbuild/issues/254)) ([2e5b3f5](https://github.com/googleapis/nodejs-cloudbuild/commit/2e5b3f540d9cd2b3a616c4581b07ebcfc444e7c7)) * Implementation of Build Failure Info: - Added message FailureInfo field ([#255](https://github.com/googleapis/nodejs-cloudbuild/issues/255)) ([6f115e2](https://github.com/googleapis/nodejs-cloudbuild/commit/6f115e2a4ec78289014c05f398d8464e599b1ef6)) ### Build System * force a minor release ([#262](https://github.com/googleapis/nodejs-cloudbuild/issues/262)) ([bc43706](https://github.com/googleapis/nodejs-cloudbuild/commit/bc4370692e233c265ce45546b205b9b9925d3990)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.3.1 (#266) :robot: I have created a release \*beep\* \*boop\* --- ### [2.3.1](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.3.0...v2.3.1) (2021-08-12) ### Bug Fixes * **build:** migrate to using main branch ([#265](https://github.com/googleapis/nodejs-cloudbuild/issues/265)) ([e89f829](https://github.com/googleapis/nodejs-cloudbuild/commit/e89f829f10c5710ca5fb259a6c8dfae1527071a3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.3.2 (#269) :robot: I have created a release \*beep\* \*boop\* --- ### [2.3.2](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.3.1...v2.3.2) (2021-08-16) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#268](https://github.com/googleapis/nodejs-cloudbuild/issues/268)) ([c26f7f7](https://github.com/googleapis/nodejs-cloudbuild/commit/c26f7f726db4f43f3692aea4c516547abcddd0ea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.4.0 (#270) :robot: I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.3.2...v2.4.0) (2021-08-16) ### Features * Add ability to configure BuildTriggers to create Builds that require approval before executing and ApproveBuild API to approve or reject pending Builds ([#267](https://github.com/googleapis/nodejs-cloudbuild/issues/267)) ([18ec067](https://github.com/googleapis/nodejs-cloudbuild/commit/18ec067ac1e112836c5d56747dda89e04f87c481)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.5.0 (#272) :robot: I have created a release \*beep\* \*boop\* --- ## [2.5.0](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.4.0...v2.5.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#271](https://github.com/googleapis/nodejs-cloudbuild/issues/271)) ([dcb970d](https://github.com/googleapis/nodejs-cloudbuild/commit/dcb970d8a6a7d87da553667cd25f8eb1052ba047)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.6.0 (#275) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * docs(samples): add example tags to generated samples (#287) * docs(samples): add example tags to generated samples PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: change node version for sample Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> * chore(quickstart): mention private pool caveats (#317) * build!: update library to use Node 12 (#325) * feat!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.0.0 (#326) * chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.0.1 (#328) :robot: I have created a release *beep* *boop* --- ## [3.0.1](googleapis/nodejs-cloudbuild@v3.0.0...v3.0.1) (2022-06-20) ### Bug Fixes * fixes for dynamic routing and streaming descriptors ([#327](googleapis/nodejs-cloudbuild#327)) ([4cf9b63](googleapis/nodejs-cloudbuild@4cf9b63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore(main): release 3.1.0 (#334) * chore(main): release 3.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.1.1 (#340) * chore(main): release 3.1.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.1.2 (#345) * chore(main): release 3.1.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * testing(cloudbuild): Add GitHub Workflows integration for test running * chore(CODEOWNERS): Add cloudbuild ownership Co-authored-by: Benjamin E. Coe <bencoe@google.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> Co-authored-by: Ace Nassri <anassri@google.com> Co-authored-by: Alexander Fenster <fenster@google.com>

…#255)

jmdobry assigned ace-n Nov 16, 2016

jmdobry force-pushed the translate branch from 10e6ddb to 22a87bb Compare November 16, 2016 17:32

jmdobry force-pushed the translate branch from 22a87bb to 3251752 Compare November 16, 2016 22:58

puneith reviewed Nov 17, 2016

View reviewed changes

puneith suggested changes Nov 17, 2016

View reviewed changes

puneith reviewed Nov 17, 2016

View reviewed changes

puneith suggested changes Nov 17, 2016

View reviewed changes

puneith reviewed Nov 17, 2016

View reviewed changes

puneith suggested changes Nov 17, 2016

View reviewed changes

ace-n reviewed Nov 17, 2016

View reviewed changes

jmdobry force-pushed the translate branch 2 times, most recently from 27aac5b to 8bb74d8 Compare November 18, 2016 15:53

ace-n approved these changes Nov 21, 2016

View reviewed changes

puneith approved these changes Nov 21, 2016

View reviewed changes

Update Translate samples, with some minor tweaks to Language samples.

f0a15e4

jmdobry force-pushed the translate branch from 8bb74d8 to f0a15e4 Compare November 21, 2016 19:26

jmdobry merged commit 6f8277c into master Nov 21, 2016

jmdobry deleted the translate branch November 21, 2016 20:57

snyk-bot mentioned this pull request Dec 23, 2020

[Snyk] Security upgrade @google-cloud/compute from 0.11.0 to 0.12.0 pedroarapua/nodejs-docs-samples-gcp#230

Open

NimJay pushed a commit that referenced this pull request Nov 9, 2022

samples: add Job Search v4 samples (#255)

2856596

telpirion mentioned this pull request Nov 9, 2022

samples(talent): migrate code from googleapis/nodejs-talent #2813

Closed

telpirion pushed a commit that referenced this pull request Nov 9, 2022

samples: add Job Search v4 samples (#255)

5384629

telpirion mentioned this pull request Nov 9, 2022

chore(talent): migrate code from googleapis/nodejs-talent #2815

Merged

telpirion pushed a commit that referenced this pull request Nov 9, 2022

samples: add Job Search v4 samples (#255)

fc77a40

NimJay pushed a commit that referenced this pull request Nov 10, 2022

Update Translate samples, with some minor tweaks to Language samples. (…

c28425d

…#255)

NimJay mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-language #2827

Merged

NimJay pushed a commit that referenced this pull request Nov 10, 2022

feat: add .repo-metadata.json and generate README (#255)

c854e1f

NimJay pushed a commit that referenced this pull request Nov 10, 2022

Update Translate samples, with some minor tweaks to Language samples. (…

4547c40

…#255)

NimJay pushed a commit that referenced this pull request Nov 10, 2022

feat: add .repo-metadata.json and generate README (#255)

a0d3f5e

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Update Translate samples, with some minor tweaks to Language samples. (…

b84446e

…#255)

ace-n mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-translate #2862

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Update Translate samples, with some minor tweaks to Language samples. (…

e40396f

…#255)

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Update Translate samples, with some minor tweaks to Language samples. (…

ff93e43

…#255)

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Update Translate samples, with some minor tweaks to Language samples. (…

2d95ca5

…#255)

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Update Translate samples, with some minor tweaks to Language samples. (…

0cdbf3f

…#255)

Shabirmean pushed a commit that referenced this pull request Feb 16, 2023

Release v0.11.0 (#255)

8f4928d

Shabirmean mentioned this pull request Feb 16, 2023

samples: migrate code from googleapis/nodejs-dlp #3035

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Translate samples, with some minor tweaks to Language samples. #255

Update Translate samples, with some minor tweaks to Language samples. #255

jmdobry commented Nov 16, 2016

ace-n commented Nov 16, 2016 •

edited

Loading

jmdobry commented Nov 16, 2016

puneith Nov 17, 2016

jmdobry Nov 17, 2016

puneith Nov 17, 2016

jmdobry Nov 17, 2016

puneith Nov 17, 2016 •

edited

Loading

jmdobry Nov 17, 2016

puneith Nov 17, 2016

jmdobry Nov 17, 2016

puneith Nov 17, 2016

puneith Nov 17, 2016

jmdobry Nov 17, 2016

puneith Nov 17, 2016

jmdobry Nov 17, 2016

puneith Nov 17, 2016

jmdobry Nov 17, 2016

puneith Nov 17, 2016

ace-n left a comment

ace-n Nov 17, 2016

jmdobry Nov 18, 2016 •

edited

Loading

ace-n Nov 17, 2016

jmdobry Nov 18, 2016

ace-n Nov 17, 2016

jmdobry Nov 18, 2016

ace-n Nov 17, 2016

jmdobry Nov 18, 2016

ace-n left a comment •

edited

Loading

		@@ -111,10 +117,12 @@ function analyzeEntitiesInFile (bucketName, fileName) {
		return document.detectEntities()

Update Translate samples, with some minor tweaks to Language samples. #255

Update Translate samples, with some minor tweaks to Language samples. #255

Conversation

jmdobry commented Nov 16, 2016

ace-n commented Nov 16, 2016 • edited Loading

jmdobry commented Nov 16, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

puneith Nov 17, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ace-n left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmdobry Nov 18, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ace-n left a comment • edited Loading

Choose a reason for hiding this comment

ace-n commented Nov 16, 2016 •

edited

Loading

puneith Nov 17, 2016 •

edited

Loading

jmdobry Nov 18, 2016 •

edited

Loading

ace-n left a comment •

edited

Loading