Upgrade apps for env:flex. #241

jmdobry · 2016-10-19T19:41:49Z

This is a large PR. It does three things for GAE apps:

Switches to env: flex (with the exception of the memcached and websockets apps)
Upgrades to use const, arrow functions, and strings templates (ES2015)
Upgrades dependencies

ace-n · 2016-10-19T23:25:29Z

appengine/analytics/app.js

      // This sample treats an event tracking error as a fatal error. Depending
      // on your application's needs, failing to track an event may not be
      // considered an error.
      if (err) {
-        return next(err);
+        next(err);
+        return;


I assume this is the new pattern to follow now? (checking for my own information)

Yes, technically, with the errback pattern, the return value of a function should be undefined, so I'm moving the return; to its own line to avoid the possibility of accidentally returning a value.

ace-n · 2016-10-19T23:45:02Z

appengine/analytics/test/app.test.js

-var path = require('path');
-var proxyquire = require('proxyquire').noPreserveCache();
-var request = require('supertest');
+const express = require(`express`);


Is this overkill/idiomatic for strings where templating isn't used?

In our tests, I've been switching to using string templates as much as possible. They're just better strings. In the sample files themselves I've only been using template strings where we need to do interpolation or concatenation.

ace-n · 2016-10-19T23:49:14Z

appengine/bower/package.json

-    "jade": "^1.11.0"
+    "bower": "^1.7.9",
+    "express": "^4.14.0",
+    "pug": "^2.0.0-beta6"


FWIW, I was holding off on switching to Pug until it was out of beta for nodejs-getting-started. (Should one of us change, or is it more personal preference?)

Jade should no longer be used (legal issues). Pug is just the Jade project renamed to Pug, so the code is quite battle-tested. Go ahead and switch to Pug.

ace-n · 2016-10-19T23:51:05Z

appengine/cloudsql/createTables.js

+  userIp VARCHAR(46) NULL,
+  PRIMARY KEY (id)
+);
+`;


Nit: should this be on its own line?

ace-n · 2016-10-19T23:53:23Z

appengine/cloudsql/server.js

+FROM visits
+ORDER BY timestamp DESC
+LIMIT 10;
+`;


Nit: separate line?

ace-n · 2016-10-20T00:30:53Z

appengine/memcached/app.js

    }
    if (value) {
-      return res.status(200).send('Value: ' + value);
+      res.status(200).send('Value: ' + value);


Template strings?

ace-n · 2016-10-20T00:32:46Z

appengine/redis/server.js

-).on('error', function (err) {
-  console.error('ERR:REDIS: ' + err);
-});
+).on('error', (err) => console.error('ERR:REDIS: ' + err));


Template strings?

No, in fact I'm making err a second argument. I have no idea what err will be, and I don't want to risk it getting stringified as [Object object]

ace-n · 2016-10-20T00:32:51Z

appengine/redis/server.js

-    console.log('Error ' + err);
-  });
+http.createServer((req, res) => {
+  client.on('error', (err) => console.log('Error ' + err));


Template strings?

See #241 (comment)

ace-n · 2016-10-20T00:35:40Z

appengine/storage/app.js

    // The public URL can be used to directly access the file via HTTP.
-    var publicUrl = format(
+    const publicUrl = format(
      'https://storage.googleapis.com/%s/%s',


Template strings?

ace-n · 2016-10-20T00:37:29Z

appengine/websockets/README.md

@@ -1,7 +1,7 @@
 # Node.js websockets sample for Google App Engine

 This sample demonstrates how to use websockets on
-[Google App Engine Managed VMs](https://cloud.google.com/appengine) with Node.js.
+[Google App Engine Flexible Environment](https://cloud.google.com/appengine) with Node.js.

 __Note:__ Secure WebSockets are currently not supported by Managed VMs.


Should we clarify that "Managed VMs" == "App Engine Flex" here? (Or otherwise not use the term "Managed VMs"?)

I'm removing all mention of Managed VMs.

codecov-io · 2016-10-20T17:23:29Z

Current coverage is 15.11% (diff: 100%)

Merging #241 into master will not change coverage

@@             master       #241   diff @@
==========================================
  Files            26         26          
  Lines          1528       1528          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            231        231          
  Misses         1297       1297          
  Partials          0          0

Powered by Codecov. Last update ba151d5...feb3363

ace-n · 2016-10-20T19:16:25Z

LGTM, merging.

jmdobry · 2016-10-20T21:28:01Z

Shoot, sorry, this wasn't supposed to be merged yet.

* Upgrade apps for env:flex. * Address comments. * Fix lint. * Address comments.

* chore(deps): upgrade gapic-generator-java to 2.4.1 PiperOrigin-RevId: 422607515 Source-Link: googleapis/googleapis@ba2ffd6 Source-Link: https://github.com/googleapis/googleapis-gen/commit/73ba4add239a619da567ffbd4e5730fdd6de04d3 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzNiYTRhZGQyMzlhNjE5ZGE1NjdmZmJkNGU1NzMwZmRkNmRlMDRkMyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.4](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.2.3...v2.2.4) (2021-06-24) ### Bug Fixes * make request optional in all cases ([#241](https://github.com/googleapis/nodejs-cloudbuild/issues/241)) ([c96003a](https://github.com/googleapis/nodejs-cloudbuild/commit/c96003a4897d3f7c8181a56c273b842a4dcdfbf7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* feat: initial release of cloud build library (#2) * feat(docs): add listBuildTriggers sample to README (#5) * feat: moves library to TypeScript code generation (#10) * chore: release 1.0.0 (#3) * chore: release 1.1.0 (#20) * chore: update license headers * chore: release 1.2.0 (#25) * chore: release 1.3.0 (#33) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore(deps): update dependency c8 to v7 (#38) * refactor: use explicit mocha imports (#40) * chore(deps): update dependency mocha to v7 (#43) * chore: release 1.3.1 * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore: release 1.3.2 (#49) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] * chore: release 1.3.3 (#59) * chore: release 1.4.0 (#63) * chore: release 1.5.0 (#67) * chore(deps): update dependency mocha to v8 (#122) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://github.com/mochajs/mocha)) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/mocha/7.2.0/8.0.1) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v8.0.1`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#801--2020-06-10) [Compare Source](https://github.com/mochajs/mocha/compare/v8.0.0...v8.0.1) The obligatory patch after a major. #### 🐛 Fixes - [#4328](https://github.com/mochajs/mocha/issues/4328): Fix `--parallel` when combined with `--watch` ([**@boneskull**](https://github.com/boneskull)) ### [`v8.0.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#800--2020-06-10) [Compare Source](https://github.com/mochajs/mocha/compare/v7.2.0...v8.0.0) In this major release, Mocha adds the ability to _run tests in parallel_. Better late than never! Please note the **breaking changes** detailed below. Let's welcome [**@giltayar**](https://github.com/giltayar) and [**@nicojs**](https://github.com/nicojs) to the maintenance team! #### 💥 Breaking Changes - [#4164](https://github.com/mochajs/mocha/issues/4164): **Mocha v8.0.0 now requires Node.js v10.0.0 or newer.** Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 ([**@UlisesGascon**](https://github.com/UlisesGascon)) - [#4175](https://github.com/mochajs/mocha/issues/4175): Having been deprecated with a warning since v7.0.0, **`mocha.opts` is no longer supported** ([**@juergba**](https://github.com/juergba)) ✨ **WORKAROUND:** Replace `mocha.opts` with a [configuration file](https://mochajs.org/#configuring-mocha-nodejs). - [#4260](https://github.com/mochajs/mocha/issues/4260): Remove `enableTimeout()` (`this.enableTimeout()`) from the context object ([**@craigtaub**](https://github.com/craigtaub)) ✨ **WORKAROUND:** Replace usage of `this.enableTimeout(false)` in your tests with `this.timeout(0)`. - [#4315](https://github.com/mochajs/mocha/issues/4315): The `spec` option no longer supports a comma-delimited list of files ([**@juergba**](https://github.com/juergba)) ✨ **WORKAROUND**: Use an array instead (e.g., `"spec": "foo.js,bar.js"` becomes `"spec": ["foo.js", "bar.js"]`). - [#4309](https://github.com/mochajs/mocha/issues/4309): Drop support for Node.js v13.x line, which is now End-of-Life ([**@juergba**](https://github.com/juergba)) - [#4282](https://github.com/mochajs/mocha/issues/4282): `--forbid-only` will throw an error even if exclusive tests are avoided via `--grep` or other means ([**@arvidOtt**](https://github.com/arvidOtt)) - [#4223](https://github.com/mochajs/mocha/issues/4223): The context object's `skip()` (`this.skip()`) in a "before all" (`before()`) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites ([**@juergba**](https://github.com/juergba)) - [#4178](https://github.com/mochajs/mocha/issues/4178): Remove previously soft-deprecated APIs ([**@wnghdcjfe**](https://github.com/wnghdcjfe)): - `Mocha.prototype.ignoreLeaks()` - `Mocha.prototype.useColors()` - `Mocha.prototype.useInlineDiffs()` - `Mocha.prototype.hideDiff()` #### 🎉 Enhancements - [#4245](https://github.com/mochajs/mocha/issues/4245): Add ability to run tests in parallel for Node.js (see [docs](https://mochajs.org/#parallel-tests)) ([**@boneskull**](https://github.com/boneskull)) ❗ See also [#4244](https://github.com/mochajs/mocha/issues/4244); [Root Hook Plugins (docs)](https://mochajs.org/#root-hook-plugins) -- _root hooks must be defined via Root Hook Plugins to work in parallel mode_ - [#4304](https://github.com/mochajs/mocha/issues/4304): `--require` now works with ES modules ([**@JacobLey**](https://github.com/JacobLey)) - [#4299](https://github.com/mochajs/mocha/issues/4299): In some circumstances, Mocha can run ES modules under Node.js v10 -- _use at your own risk!_ ([**@giltayar**](https://github.com/giltayar)) #### 📖 Documentation - [#4246](https://github.com/mochajs/mocha/issues/4246): Add documentation for parallel mode and Root Hook plugins ([**@boneskull**](https://github.com/boneskull)) #### 🐛 Fixes (All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above) </details> --- ### Renovate configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-cloudbuild). * chore: release 2.0.0 (#92) :robot: I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://github.com/googleapis/nodejs-cloudbuild/compare/v1.5.0...v2.0.0) (2020-06-11) ### ⚠ BREAKING CHANGES * The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM. ### Features * add time-to-live in a queue for builds ([04e3387](https://github.com/googleapis/nodejs-cloudbuild/commit/04e3387af33a7ab39eb0c4df47ce08026507b499)) * check status of long running operation by its name ([#114](https://github.com/googleapis/nodejs-cloudbuild/issues/114)) ([7b50a74](https://github.com/googleapis/nodejs-cloudbuild/commit/7b50a74c098e782393f92140a37e3bd26f45e77d)) * drop node8 support, support for async iterators ([#91](https://github.com/googleapis/nodejs-cloudbuild/issues/91)) ([74a195d](https://github.com/googleapis/nodejs-cloudbuild/commit/74a195d5cdf63dab1ac3d0d52ef42e1254ab3a2e)) * improve support for x-goog-request-params ([#111](https://github.com/googleapis/nodejs-cloudbuild/issues/111)) ([e08d640](https://github.com/googleapis/nodejs-cloudbuild/commit/e08d64017e059c911ebe55055c26a0ab76481d86)) * move ts target to es2018 from es2016 ([#121](https://github.com/googleapis/nodejs-cloudbuild/issues/121)) ([59c5477](https://github.com/googleapis/nodejs-cloudbuild/commit/59c547744519ef9e8d073ea3ecdb81248176a71a)) ### Bug Fixes * remove eslint, update gax, fix generated protos, run the generator ([#100](https://github.com/googleapis/nodejs-cloudbuild/issues/100)) ([aafb9cc](https://github.com/googleapis/nodejs-cloudbuild/commit/aafb9cc7745b4d5d6dce58f17763f76379af733f)) * synth.py clean up for multiple version ([#115](https://github.com/googleapis/nodejs-cloudbuild/issues/115)) ([aa7d99b](https://github.com/googleapis/nodejs-cloudbuild/commit/aa7d99b9c02267808cac07f7691f5ce62f06ca14)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.0.1 (#126) * updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.0.2 (#133) :robot: I have created a release \*beep\* \*boop\* --- ### [2.0.2](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.0.1...v2.0.2) (2020-07-09) ### Bug Fixes * typeo in nodejs .gitattribute ([#132](https://github.com/googleapis/nodejs-cloudbuild/issues/132)) ([80b5bd9](https://github.com/googleapis/nodejs-cloudbuild/commit/80b5bd963aa43e5a47da9e6d0e2ffbf0cde7feef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.0.3 (#143) * chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.0.4 (#179) :robot: I have created a release \*beep\* \*boop\* --- ### [2.0.4](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.0.3...v2.0.4) (2020-11-03) ### ⚠ BREAKING CHANGES * The WorkerPool API in the v1 surface has been long deprecated, so it has been deleted from the v1 surface. Alpha WorkerPool customers who want to call the WorkerPool API can use gcloud. ### Features * updated third_party Cloud Build clients with new Build message, fix: revert removal of WorkerPool API ([#166](https://github.com/googleapis/nodejs-cloudbuild/issues/166)) ([b8d7a39](https://github.com/googleapis/nodejs-cloudbuild/commit/b8d7a395bbcc2f6ff83b798ef678e2f27395802d)) ### Bug Fixes * revert removal of WorkerPool API ([#178](https://github.com/googleapis/nodejs-cloudbuild/issues/178)) ([07400cb](https://github.com/googleapis/nodejs-cloudbuild/commit/07400cbcb05808762ab3c56c5827607cdefd43c0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.0.5 (#182) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.0.6 (#186) :robot: I have created a release \*beep\* \*boop\* --- ### [2.0.6](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.0.5...v2.0.6) (2020-11-25) ### Bug Fixes * check for fetch on window ([#185](https://github.com/googleapis/nodejs-cloudbuild/issues/185)) ([115de71](https://github.com/googleapis/nodejs-cloudbuild/commit/115de7141262c119113759aee5ddc141d129b55d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * chore: release 2.1.0 (#205) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.0 (#213) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com> * chore: release 2.2.1 (#220) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.2 (#227) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.3 (#232) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.4 (#242) :robot: I have created a release \*beep\* \*boop\* --- ### [2.2.4](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.2.3...v2.2.4) (2021-06-24) ### Bug Fixes * make request optional in all cases ([#241](https://github.com/googleapis/nodejs-cloudbuild/issues/241)) ([c96003a](https://github.com/googleapis/nodejs-cloudbuild/commit/c96003a4897d3f7c8181a56c273b842a4dcdfbf7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.2.5 (#247) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.6 (#250) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: release 2.2.7 (#252) :robot: I have created a release \*beep\* \*boop\* --- ### [2.2.7](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.2.6...v2.2.7) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#251](https://github.com/googleapis/nodejs-cloudbuild/issues/251)) ([7bc5f7f](https://github.com/googleapis/nodejs-cloudbuild/commit/7bc5f7ff6c1485baaf1444a608d8ebb88ad20cfe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.3.0 (#263) :robot: I have created a release \*beep\* \*boop\* --- ## [2.3.0](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.2.7...v2.3.0) (2021-08-05) ### ⚠ BREAKING CHANGES * * feat: add a WorkerPools API ### Features * add a WorkerPools API ([#254](https://github.com/googleapis/nodejs-cloudbuild/issues/254)) ([2e5b3f5](https://github.com/googleapis/nodejs-cloudbuild/commit/2e5b3f540d9cd2b3a616c4581b07ebcfc444e7c7)) * Implementation of Build Failure Info: - Added message FailureInfo field ([#255](https://github.com/googleapis/nodejs-cloudbuild/issues/255)) ([6f115e2](https://github.com/googleapis/nodejs-cloudbuild/commit/6f115e2a4ec78289014c05f398d8464e599b1ef6)) ### Build System * force a minor release ([#262](https://github.com/googleapis/nodejs-cloudbuild/issues/262)) ([bc43706](https://github.com/googleapis/nodejs-cloudbuild/commit/bc4370692e233c265ce45546b205b9b9925d3990)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.3.1 (#266) :robot: I have created a release \*beep\* \*boop\* --- ### [2.3.1](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.3.0...v2.3.1) (2021-08-12) ### Bug Fixes * **build:** migrate to using main branch ([#265](https://github.com/googleapis/nodejs-cloudbuild/issues/265)) ([e89f829](https://github.com/googleapis/nodejs-cloudbuild/commit/e89f829f10c5710ca5fb259a6c8dfae1527071a3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.3.2 (#269) :robot: I have created a release \*beep\* \*boop\* --- ### [2.3.2](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.3.1...v2.3.2) (2021-08-16) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#268](https://github.com/googleapis/nodejs-cloudbuild/issues/268)) ([c26f7f7](https://github.com/googleapis/nodejs-cloudbuild/commit/c26f7f726db4f43f3692aea4c516547abcddd0ea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.4.0 (#270) :robot: I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.3.2...v2.4.0) (2021-08-16) ### Features * Add ability to configure BuildTriggers to create Builds that require approval before executing and ApproveBuild API to approve or reject pending Builds ([#267](https://github.com/googleapis/nodejs-cloudbuild/issues/267)) ([18ec067](https://github.com/googleapis/nodejs-cloudbuild/commit/18ec067ac1e112836c5d56747dda89e04f87c481)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.5.0 (#272) :robot: I have created a release \*beep\* \*boop\* --- ## [2.5.0](https://github.com/googleapis/nodejs-cloudbuild/compare/v2.4.0...v2.5.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#271](https://github.com/googleapis/nodejs-cloudbuild/issues/271)) ([dcb970d](https://github.com/googleapis/nodejs-cloudbuild/commit/dcb970d8a6a7d87da553667cd25f8eb1052ba047)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 2.6.0 (#275) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * docs(samples): add example tags to generated samples (#287) * docs(samples): add example tags to generated samples PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: change node version for sample Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> * chore(quickstart): mention private pool caveats (#317) * build!: update library to use Node 12 (#325) * feat!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.0.0 (#326) * chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.0.1 (#328) :robot: I have created a release *beep* *boop* --- ## [3.0.1](googleapis/nodejs-cloudbuild@v3.0.0...v3.0.1) (2022-06-20) ### Bug Fixes * fixes for dynamic routing and streaming descriptors ([#327](googleapis/nodejs-cloudbuild#327)) ([4cf9b63](googleapis/nodejs-cloudbuild@4cf9b63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore(main): release 3.1.0 (#334) * chore(main): release 3.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.1.1 (#340) * chore(main): release 3.1.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 3.1.2 (#345) * chore(main): release 3.1.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * testing(cloudbuild): Add GitHub Workflows integration for test running * chore(CODEOWNERS): Add cloudbuild ownership Co-authored-by: Benjamin E. Coe <bencoe@google.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Olivier Bourgeois <3271352+bourgeoisor@users.noreply.github.com> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> Co-authored-by: Ace Nassri <anassri@google.com> Co-authored-by: Alexander Fenster <fenster@google.com>

* Upgrade apps for env:flex. * Address comments. * Fix lint. * Address comments.

* updated CHANGELOG.md * updated package.json * updated samples/package.json

…se mocha (#241)

* updated CHANGELOG.md * updated package.json * updated samples/package.json

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

* Upgrade apps for env:flex. * Address comments. * Fix lint. * Address comments.

Upgrade apps for env:flex.

6290335

jmdobry assigned ace-n Oct 19, 2016

ace-n reviewed Oct 20, 2016

View reviewed changes

jmdobry added 2 commits October 20, 2016 09:44

Address comments.

265d055

Fix lint.

f38f59b

Address comments.

feb3363

ace-n merged commit a4eb913 into master Oct 20, 2016

jmdobry mentioned this pull request Oct 20, 2016

Revert "Upgrade apps for env:flex." #242

Merged

jmdobry added a commit that referenced this pull request Oct 20, 2016

Upgrade apps for env:flex. (#241)

ae366f2

* Upgrade apps for env:flex. * Address comments. * Fix lint. * Address comments.

grayside pushed a commit that referenced this pull request Oct 26, 2022

docs: fix HTTP acronym (#241)

f615737

grayside mentioned this pull request Oct 26, 2022

migrate code from googleapis/nodejs-tasks #2792

Merged

grayside pushed a commit that referenced this pull request Nov 3, 2022

docs: fix HTTP acronym (#241)

4d3a1a7

pattishin mentioned this pull request Nov 9, 2022

migrate code from googleapis/nodejs-game-servers #2818

Closed

NimJay pushed a commit that referenced this pull request Nov 11, 2022

feat(samples): add asymmetric samples (#241)

fa6928a

NimJay mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-kms #2839

Merged

ace-n pushed a commit that referenced this pull request Nov 11, 2022

feat(samples): add asymmetric samples (#241)

f3e72c1

ace-n pushed a commit that referenced this pull request Nov 14, 2022

Upgrade apps for env:flex. (#241)

b3f7a9a

* Upgrade apps for env:flex. * Address comments. * Fix lint. * Address comments.

This was referenced Nov 14, 2022

migrate code from googleapis/nodejs-compute #2846

Closed

migrate code from googleapis/nodejs-compute #2853

Merged

ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022

chore(deps): update dependency mocha to v7 (#241)

f6f1ca2

ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022

chore(deps): update dependency mocha to v7 (#241)

ccafb25

ace-n pushed a commit that referenced this pull request Nov 16, 2022

chore: release 2.0.1 (#241)

66c3e5a

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022

chore(deps): update dependency mocha to v7 (#241)

3b72de4

ace-n mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-video-intelligence #2855

Merged

ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022

chore(deps): update dependency mocha to v7 (#241)

483b67b

ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022

chore(deps): update dependency mocha to v7 (#241)

90fc913

ahrarmonsur mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-asset #2856

Merged

telpirion mentioned this pull request Nov 16, 2022

chore(vision): migrate code from googleapis/nodejs-vision #2858

Merged

telpirion pushed a commit that referenced this pull request Nov 16, 2022

docs(samples): updated samples code to use async/await and tests to u…

b876b17

…se mocha (#241)

grayside pushed a commit that referenced this pull request Nov 16, 2022

chore: release 1.3.1 (#241)

f6f1d4a

This was referenced Nov 16, 2022

migrate code from googleapis/nodejs-cloud-container #2859

Closed

migrate code from googleapis/nodejs-cloud-container #2860

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: release 2.0.1 (#241)

fedb7f9

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: release 1.3.1 (#241)

db18e23

grayside pushed a commit that referenced this pull request Nov 17, 2022

chore: release 1.3.1 (#241)

e0c3818

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency mocha to v7 (#241)

94ab045

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

chore: release 2.0.1 (#241)

7ca8524

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

chore: release 1.3.1 (#241)

4c6de39

NimJay pushed a commit that referenced this pull request Nov 19, 2022

chore: release 1.2.4 (#241)

2c08fd6

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

NimJay mentioned this pull request Nov 19, 2022

migrate code from googleapis/nodejs-dataproc #2878

Merged

NimJay pushed a commit that referenced this pull request Nov 19, 2022

chore: release 1.2.4 (#241)

8479f32

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

ace-n pushed a commit that referenced this pull request Nov 21, 2022

Upgrade apps for env:flex. (#241)

bd0e674

* Upgrade apps for env:flex. * Address comments. * Fix lint. * Address comments.

ace-n pushed a commit that referenced this pull request Nov 21, 2022

Upgrade apps for env:flex. (#241)

039577f

* Upgrade apps for env:flex. * Address comments. * Fix lint. * Address comments.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade apps for env:flex. #241

Upgrade apps for env:flex. #241

jmdobry commented Oct 19, 2016

ace-n Oct 19, 2016

jmdobry Oct 20, 2016

ace-n Oct 19, 2016

jmdobry Oct 20, 2016

ace-n Oct 19, 2016

jmdobry Oct 20, 2016

ace-n Oct 19, 2016

jmdobry Oct 20, 2016

ace-n Oct 19, 2016

jmdobry Oct 20, 2016

ace-n Oct 20, 2016

jmdobry Oct 20, 2016

ace-n Oct 20, 2016

jmdobry Oct 20, 2016

ace-n Oct 20, 2016

jmdobry Oct 20, 2016

ace-n Oct 20, 2016

jmdobry Oct 20, 2016

ace-n Oct 20, 2016

jmdobry Oct 20, 2016

codecov-io commented Oct 20, 2016 •

edited

Loading

ace-n commented Oct 20, 2016

jmdobry commented Oct 20, 2016

Upgrade apps for env:flex. #241

Upgrade apps for env:flex. #241

Conversation

jmdobry commented Oct 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Oct 20, 2016 • edited Loading

Current coverage is 15.11% (diff: 100%)

ace-n commented Oct 20, 2016

jmdobry commented Oct 20, 2016

codecov-io commented Oct 20, 2016 •

edited

Loading