Don't wait for Page.navigate's resolution #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Sep 26, 2017
lighthouse-core/gather/driver.js
Outdated
| .then(_ => this.sendCommand('Page.navigate', {url})) | ||
| .then(_ => { | ||
| // These can 'race' and that's OK. | ||
| // We don't want to wait for Page.navigate's resolution, as it can happen _after_ onload. |
i noticed example.com was timing out. patrick picked up on the race issue here. |
paulirish
added a commit
that referenced
this pull request
Sep 26, 2017
paulirish
added a commit
that referenced
this pull request
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to repro:
yarn start -- --disable-device-emulation --disable-cpu-throttling --disable-network-throttling "http://example.com" --verbosethis will always timeout at 30 waiting for example.com
that's because it fires loadEventFired before page.navigate ever resolves: