Don't wait for Page.navigate's resolution (#3413)

GoogleChrome · Sep 26, 2017 · 43e93bc · 43e93bc
1 parent b212dc7
commit 43e93bc
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lighthouse-core/gather/driver.js b/lighthouse-core/gather/driver.js
@@ -622,9 +622,14 @@ class Driver {
     /* eslint-enable max-len */
 
     return this._beginNetworkStatusMonitoring(url)
-      .then(_ => this.sendCommand('Page.enable'))
-      .then(_ => this.sendCommand('Emulation.setScriptExecutionDisabled', {value: disableJS}))
-      .then(_ => this.sendCommand('Page.navigate', {url}))
+      .then(_ => {
+        // These can 'race' and that's OK.
+        // We don't want to wait for Page.navigate's resolution, as it can now
+        // happen _after_ onload: https://crbug.com/768961
+        this.sendCommand('Page.enable');
+        this.sendCommand('Emulation.setScriptExecutionDisabled', {value: disableJS});
+        this.sendCommand('Page.navigate', {url});
+      })
       .then(_ => waitForLoad && this._waitForFullyLoaded(pauseAfterLoadMs,
           networkQuietThresholdMs, cpuQuietThresholdMs, maxWaitMs))
       .then(_ => this._endNetworkStatusMonitoring());