-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for new block variations 3/x: block variation loading #898
Open
carstingaxion
wants to merge
30
commits into
GatherPress:main
Choose a base branch
from
carstingaxion:feature/block-variation-loading
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Prepare for new block variations 3/x: block variation loading #898
carstingaxion
wants to merge
30
commits into
GatherPress:main
from
carstingaxion:feature/block-variation-loading
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…former source was deprecated in 6.6)
Preview changes with PlaygroundYou can preview the recent changes for PR#898 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation to bring some block variations from the gatherpress-block-playground into the plugin as part of #626.
While current blocks can rely on
register_block_type()
to get everything in place, block variations need more manual attention.Description of the Change
With this PR, I try to outline a possible way to load all variations the same way.
Because most of the variations need some extra php to work, I went with a singleton, that gets automatically copied from
/src
to/build
and lives in the folder of the variation. For this reason the autoloader doesn’t know about the classes and that’s why I required them manually.Could this be done nicer @mauteri ??
Closes #How to test the Change
Changelog Entry
Credits
Props @carstingaxion
Checklist: