Prepare for new block variations 1/x: hookable-patterns, slot-fills & docs #888
+238
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…former source was deprecated in 6.6)
carstingaxion
changed the title
carstingaxion
changed the title
carstingaxion
changed the title
mauteri
requested changes
Sep 19, 2024
| \register_block_pattern( | ||
| 'gatherpress/event-template', | ||
| array( | ||
| 'title' => 'Invisible Event Template Block Pattern', |
There was a problem hiding this comment.
Needs internationalization __().
There was a problem hiding this comment.
This is a little funny.
- I had _() everywhere in place
- Than realised, that nobody will ever see this. Because it's hidden. So I removed the _() and added a comment "// Needs no i18n
- Lastly I removed the comment also, because .... I don't know.
Now I'm going to add _() again, yes.
| * when registering the 'gatherpress_event' post type | ||
| * and will not be visible to the editor at any point. | ||
| */ | ||
| \register_block_pattern( |
There was a problem hiding this comment.
Will be fixed, but I'm wondering why the CS checks didn't jump in here. Some days ago, I remember that phpcs was jelling at me because of a \WP_Query. But here, nothing. Hmmm.
4 tasks
|
Finished, but mention the two unresolved comments, please @mauteri . |
Preview changes with PlaygroundYou can preview the recent changes for PR#888 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation to bring some block variations from the gatherpress-block-playground into the plugin as part of #626.
Description of the Change
This PR does:
PluginDocumentSettingPanelfromwordpress/editorpackage (The former source was deprecated in 6.6, which led to the annoying console warnings all over the place)/docs/developer/blocks/...Closes #628
How to test the Change
Changelog Entry
Credits
Props @carstingaxion
Checklist: