Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: apply the changes of lbm-sdk and ostracon proto #9

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Feb 10, 2023

Description

Main changes

  • Remove Ostracon protobuf struct and message which same with Tendermint
  • VRF Proof move from block.header to Entropy in Block structure

warning

  • RequestBeginBlock, RequestBeginRecheckTx and RequestEndRecheckTx of abci proto are Ostracon's proto, so these should be use ostracon import(github.com/line/ostracon/abci/types)

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

- base lbm-sdk commit: b8864730859710d92a83f9f91289d4c6aef658cd
@zemyblue zemyblue marked this pull request as draft February 10, 2023 00:44
@zemyblue zemyblue self-assigned this Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #9 (68705a1) into main (e0d9c95) will not change coverage.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   60.81%   60.81%           
=======================================
  Files          80       80           
  Lines        9879     9879           
=======================================
  Hits         6008     6008           
  Misses       3555     3555           
  Partials      316      316           
Impacted Files Coverage Δ
app/test_helpers.go 0.64% <0.00%> (ø)
appplus/test_helpers.go 0.00% <ø> (ø)
x/wasm/handler.go 68.88% <ø> (ø)
x/wasm/keeper/genesis.go 87.64% <ø> (ø)
x/wasm/keeper/legacy_querier.go 66.36% <ø> (ø)
x/wasm/keeper/msg_dispatcher.go 90.07% <ø> (ø)
x/wasm/keeper/query_plugins.go 75.18% <ø> (ø)
x/wasm/module.go 33.07% <ø> (ø)
x/wasmplus/keeper/genesis.go 100.00% <ø> (ø)
x/wasmplus/module.go 60.00% <ø> (ø)
... and 5 more

@zemyblue
Copy link
Member Author

waiting for merging Finschia/ibc-go#5

@zemyblue zemyblue marked this pull request as ready for review February 10, 2023 04:22
@zemyblue
Copy link
Member Author

The coverage of the original source is low. So, I hope we ignore coverage in this PR.

Copy link

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit 9104d00 into Finschia:main Feb 10, 2023
@zemyblue zemyblue mentioned this pull request Mar 28, 2023
@zemyblue zemyblue deleted the feat/apply_lbm-sdk_changes branch April 2, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants