Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: apply the changes of vrf location in Ostracon #887

Merged
merged 9 commits into from
Feb 9, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Feb 9, 2023

Description

Main changes

  • moved Ostracon's VRF proof block header to block.
  • change ostracon block.header to tendermint block.header

Motivation and context

Ostracon's block structure is changed. So we need to change the related codes.
related: Finschia/ostracon#559

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue self-assigned this Feb 9, 2023
@zemyblue zemyblue marked this pull request as draft February 9, 2023 04:59
@zemyblue zemyblue changed the title feat: apply the changes of vrf location in Ostracon feat!: apply the changes of vrf location in Ostracon Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #887 (7ea47f3) into main (e2aa3ea) will not change coverage.
The diff coverage is 75.00%.

❗ Current head 7ea47f3 differs from pull request most recent head 752e800. Consider uploading reports for the commit 752e800 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files         652      652           
  Lines       79493    79493           
=======================================
  Hits        49534    49534           
  Misses      27279    27279           
  Partials     2680     2680           
Impacted Files Coverage Δ
simapp/test_helpers.go 9.86% <0.00%> (ø)
testutil/context.go 0.00% <0.00%> (ø)
types/abci.pb.go 0.51% <ø> (ø)
x/simulation/mock_ostracon.go 0.00% <ø> (ø)
x/simulation/simulate.go 0.00% <0.00%> (ø)
baseapp/abci.go 58.11% <100.00%> (ø)
baseapp/baseapp.go 78.66% <100.00%> (ø)
baseapp/test_helpers.go 74.28% <100.00%> (ø)
simapp/app.go 82.30% <100.00%> (ø)
simapp/export.go 12.59% <100.00%> (ø)
... and 3 more

@zemyblue zemyblue marked this pull request as ready for review February 9, 2023 06:04
@zemyblue zemyblue added this to the v0.47.0-alpha1 milestone Feb 9, 2023
@ulbqb
Copy link
Member

ulbqb commented Feb 9, 2023

Does this PR contain changes about voter election?

@zemyblue
Copy link
Member Author

zemyblue commented Feb 9, 2023

Does this PR contain changes about voter election?

No, there isn't any changes about voter selection logic in this PR. I just applied the changes of Finschia/ostracon#559.

I added the adding voter selection in lbm-sdk as issue #888 .

ulbqb
ulbqb previously approved these changes Feb 9, 2023
dudong2
dudong2 previously approved these changes Feb 9, 2023
@zemyblue zemyblue dismissed stale reviews from dudong2 and ulbqb via 752e800 February 9, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants