Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove grpc replace directive and refactor grpc-web/rosetta/grpc-gw (backport #1153, #1418) #1423

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Jun 14, 2024

Description

closes: #XXXX

#1153 #1418

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2024

CLA assistant check
All committers have signed the CLA.

@tkxkd0159 tkxkd0159 changed the base branch from main to release/v0.49.x June 14, 2024 10:06
@tkxkd0159 tkxkd0159 self-assigned this Jun 14, 2024
@tkxkd0159 tkxkd0159 changed the title fix: remove grpc replace directive (backport #1153) fix: remove grpc replace directive and refactor grpc-web/rosetta (backport #1153, #1418) Jun 17, 2024
@tkxkd0159 tkxkd0159 changed the title fix: remove grpc replace directive and refactor grpc-web/rosetta (backport #1153, #1418) fix: remove grpc replace directive and refactor grpc-web/rosetta/grpc (backport #1153, #1418) Jun 17, 2024
@tkxkd0159 tkxkd0159 changed the title fix: remove grpc replace directive and refactor grpc-web/rosetta/grpc (backport #1153, #1418) fix: remove grpc replace directive and refactor grpc-web/rosetta/grpc-gw (backport #1153, #1418) Jun 17, 2024
@tkxkd0159 tkxkd0159 added A: improvement Changes in existing functionality C:server dependencies Pull requests that update a dependency file labels Jun 17, 2024
@tkxkd0159 tkxkd0159 marked this pull request as ready for review June 17, 2024 08:18
@tkxkd0159 tkxkd0159 requested a review from 170210 June 17, 2024 08:19
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 50.59524% with 83 lines in your changes missing coverage. Please review.

Project coverage is 68.95%. Comparing base (cc37bdb) to head (ad4e4e9).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.49.x    #1423      +/-   ##
===================================================
+ Coverage            68.08%   68.95%   +0.86%     
===================================================
  Files                  770      754      -16     
  Lines                77606    76124    -1482     
===================================================
- Hits                 52840    52489     -351     
+ Misses               22097    20996    -1101     
+ Partials              2669     2639      -30     
Files Coverage Δ
baseapp/grpcrouter.go 85.48% <100.00%> (-0.46%) ⬇️
baseapp/grpcrouter_helpers.go 25.00% <100.00%> (-4.63%) ⬇️
server/config/config.go 45.90% <ø> (-0.36%) ⬇️
server/config/toml.go 20.00% <ø> (ø)
simapp/simd/cmd/root.go 87.74% <ø> (-0.18%) ⬇️
telemetry/metrics.go 56.94% <ø> (ø)
telemetry/wrapper.go 0.00% <ø> (ø)
x/auth/vesting/msg_server.go 67.27% <ø> (ø)
x/bank/keeper/msg_server.go 3.84% <ø> (ø)
x/distribution/keeper/msg_server.go 2.66% <ø> (ø)
... and 10 more

@tkxkd0159 tkxkd0159 merged commit 2350c1a into release/v0.49.x Jun 17, 2024
28 of 29 checks passed
@tkxkd0159 tkxkd0159 deleted the 049-bump-grpc branch June 17, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality C:server dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants