Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove grpc replace directive #1153

Merged
merged 4 commits into from
Oct 24, 2023
Merged

fix: remove grpc replace directive #1153

merged 4 commits into from
Oct 24, 2023

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Oct 20, 2023

Description

closes: #XXXX
A backport of cosmos/cosmos-sdk#11089

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 self-assigned this Oct 20, 2023
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add the reference to the description.
e.g. Refer: cosmos/cosmos-sdk#11089

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #1153 (8168428) into main (fa2e357) will decrease coverage by 0.04%.
The diff coverage is 23.07%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
- Coverage   69.80%   69.76%   -0.04%     
==========================================
  Files         646      646              
  Lines       67554    67593      +39     
==========================================
+ Hits        47158    47159       +1     
- Misses      18210    18246      +36     
- Partials     2186     2188       +2     
Files Coverage Δ
baseapp/grpcrouter.go 85.48% <100.00%> (-0.46%) ⬇️
baseapp/grpcrouter_helpers.go 25.00% <100.00%> (-4.63%) ⬇️
server/grpc/server.go 63.82% <100.00%> (+0.78%) ⬆️
server/rosetta/client_online.go 1.70% <0.00%> (ø)
client/grpc_query.go 30.95% <21.73%> (-5.56%) ⬇️
server/grpc/gogoreflection/serverreflection.go 2.56% <0.00%> (ø)
codec/proto_codec.go 62.22% <21.42%> (-12.12%) ⬇️

... and 1 file with indirect coverage changes

@tkxkd0159 tkxkd0159 requested a review from 0Tech October 20, 2023 08:16
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkxkd0159 tkxkd0159 merged commit 2bee1fb into main Oct 24, 2023
37 of 38 checks passed
@tkxkd0159 tkxkd0159 deleted the remove-grpc-replace1 branch October 24, 2023 03:49
@tkxkd0159 tkxkd0159 added A: improvement Changes in existing functionality and removed hotfix labels Oct 27, 2023
jaeseung-bae pushed a commit to jaeseung-bae/finschia-sdk that referenced this pull request May 7, 2024
tkxkd0159 added a commit that referenced this pull request Jun 17, 2024
…-gw (backport #1153, #1418) (#1423)

* backport finschia-sdk#1153

* backport finschia-sdk#1418

* Keep using Ostracon under tm naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants