don't compile WIN32 stuff when iconv is present #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinGW has iconv, so this block of code can go away. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2575 +/- ##
=======================================
Coverage 63.93% 63.93%
=======================================
Files 103 103
Lines 22381 22381
Branches 10823 10823
=======================================
Hits 14309 14309
Misses 5851 5851
Partials 2221 2221
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
No this PR just builds one or the other on Windows. |
kmilos
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinGW has iconv, so this block of code can go away.