-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson CI: add FreeBSD and MSYS #2553
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2553 +/- ##
=======================================
Coverage 63.93% 63.93%
=======================================
Files 103 103
Lines 22381 22381
Branches 10823 10823
=======================================
Hits 14309 14309
Misses 5851 5851
Partials 2221 2221
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3fd434b
to
201dfe0
Compare
0a84a6b
to
af60493
Compare
ca795a5
to
b364e04
Compare
a6ac2ed
to
ea19a45
Compare
Modified to build on both FreeBSD and MSYS2. Fixed bugs there. |
Remove geotag and iconv changes as they are separate PRs now? |
iconv change is actually a fix for FreeBSD. geotag for MSYS2. |
Bug was fixed. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
There's no need for it anymore. All static bugs (mostly on Windows) were fixed. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rebased |
In theory could move the MSYS2 CLANG runs into the other workflow file, but it's 50/50 how you want to organize this... Could also merge everything in one large workflow, e.g. like this... But what matters is that coverage is there for now I guess. |
I'll probably do so in the future. |
Btw, even w/ the reduction, our CI is still running 100+ jobs and takes more than 1h. I personally don't think that's sustainable (nor that useful) to do in the long run for every single PR. |
right. the MSVC meson CI can be sped up if /analyze is eliminated. I'll reduce the CI checks in a future PR. |
Fixes: #2104