Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson CI: add FreeBSD and MSYS #2553

Merged
merged 4 commits into from
Apr 4, 2023
Merged

meson CI: add FreeBSD and MSYS #2553

merged 4 commits into from
Apr 4, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Mar 19, 2023

Fixes: #2104

@ghost
Copy link

ghost commented Mar 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #2553 (33553b6) into main (3633f8d) will not change coverage.
The diff coverage is 66.66%.

❗ Current head 33553b6 differs from pull request most recent head ea19a45. Consider uploading reports for the commit ea19a45 to get more accurate results

@@           Coverage Diff           @@
##             main    #2553   +/-   ##
=======================================
  Coverage   63.93%   63.93%           
=======================================
  Files         103      103           
  Lines       22381    22381           
  Branches    10823    10823           
=======================================
  Hits        14309    14309           
  Misses       5851     5851           
  Partials     2221     2221           
Impacted Files Coverage Δ
src/convert.cpp 52.50% <66.66%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb neheb changed the title meson CI: add FreeBSD meson CI: add FreeBSD and MSYS Apr 3, 2023
@neheb
Copy link
Collaborator Author

neheb commented Apr 3, 2023

Modified to build on both FreeBSD and MSYS2. Fixed bugs there.

@neheb neheb requested a review from kmilos April 3, 2023 23:09
@kmilos
Copy link
Collaborator

kmilos commented Apr 4, 2023

Remove geotag and iconv changes as they are separate PRs now?

@neheb
Copy link
Collaborator Author

neheb commented Apr 4, 2023

iconv change is actually a fix for FreeBSD. geotag for MSYS2.

@kmilos
Copy link
Collaborator

kmilos commented Apr 4, 2023

iconv change is actually a fix for FreeBSD. geotag for MSYS2.

Sure, but what about #2575 and #2577, they look identical to me?

Merge those first, and then rebase this one?

Bug was fixed.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
There's no need for it anymore. All static bugs (mostly on Windows)
were fixed.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
Copy link
Collaborator Author

neheb commented Apr 4, 2023

Rebased

@kmilos
Copy link
Collaborator

kmilos commented Apr 4, 2023

In theory could move the MSYS2 CLANG runs into the other workflow file, but it's 50/50 how you want to organize this... Could also merge everything in one large workflow, e.g. like this... But what matters is that coverage is there for now I guess.

@neheb
Copy link
Collaborator Author

neheb commented Apr 4, 2023

I'll probably do so in the future.

@kmilos
Copy link
Collaborator

kmilos commented Apr 4, 2023

Btw, even w/ the reduction, our CI is still running 100+ jobs and takes more than 1h.

I personally don't think that's sustainable (nor that useful) to do in the long run for every single PR.

@neheb neheb merged commit 971bbfa into Exiv2:main Apr 4, 2023
@neheb neheb deleted the r branch April 4, 2023 18:23
@neheb
Copy link
Collaborator Author

neheb commented Apr 4, 2023

right. the MSVC meson CI can be sped up if /analyze is eliminated. I'll reduce the CI checks in a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FreeBSD to CI
2 participants