Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover IptDataSets::recordId in the API #2137

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Conversation

piponazo
Copy link
Collaborator

As it has been pointed out by @jim-easterbrook here , IptcDataSets::recordId was declared in datasets.hpp but not defined in datasets.cpp (it was actually defined but just as an implementation detail).

In #2060 I was too aggressive and not careful with some changes in the API. That's why I am recovering that function as part of the API.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2137 (c1ae1bc) into main (89e66ff) will not change coverage.
The diff coverage is 72.72%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2137   +/-   ##
=======================================
  Coverage   63.35%   63.35%           
=======================================
  Files          97       97           
  Lines       19174    19174           
  Branches     9712     9712           
=======================================
  Hits        12148    12148           
  Misses       4758     4758           
  Partials     2268     2268           
Impacted Files Coverage Δ
src/datasets.cpp 93.03% <72.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e66ff...c1ae1bc. Read the comment docs.

@piponazo piponazo merged commit 5c36c69 into main Mar 10, 2022
@piponazo piponazo deleted the mainRecoverRecordId branch March 10, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants