Extend unit tests for BMP & Datasets #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piponazo
force-pushed
the
main_bmpTests
branch
from
b561564
to
6944c61
Compare
Codecov Report
@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
+ Coverage 61.48% 61.83% +0.34%
==========================================
Files 96 96
Lines 19207 19100 -107
Branches 9843 9817 -26
==========================================
Hits 11810 11810
+ Misses 5080 4995 -85
+ Partials 2317 2295 -22
Continue to review full report at Codecov.
|
piponazo
requested review from
hassec,
clanmills,
kevinbackhouse and
kmilos
and removed request for
hassec
hassec
previously approved these changes
Feb 4, 2022
hassec
reviewed
Feb 4, 2022
No way to obtain nullptr DataSet* when we are checking already the 2 only existing DataSets above.
piponazo
force-pushed
the
main_bmpTests
branch
from
6944c61
to
a425018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I am continuing with the addition of unit tests for some parts of the code that I am analysing. I try to focus on some areas of the code which were not covered by either unit tests or the python tests.
NOTE: I am also opening the PR as DRAFT so that I can check what is going wrong with the codecov reports. I'll do some modifications there aiming to get more stable results.
UPDATE: I found out that the difference between codecov (61.49%) and the local coverage reports (75.1%) is due to the different treatment of partial coverage. While locally a partial coverage is treated as a HIT, in codecov is treated as a MISS: https://docs.codecov.com/docs/frequently-asked-questions#how-is-coverage-calculated