Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring & cleanup #2109

Merged
merged 25 commits into from
Feb 21, 2022
Merged

Refactoring & cleanup #2109

merged 25 commits into from
Feb 21, 2022

Commits on Feb 18, 2022

  1. Improvements in urlencode

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    3d370cc View commit details
    Browse the repository at this point in the history

  2. Make urldecode in-place

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    f1ff3aa View commit details
    Browse the repository at this point in the history

  3. Use std::filesystem for fileExist

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    6f762b4 View commit details
    Browse the repository at this point in the history

  4. Hide pathOfFileUrl in the only place where it is used

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    0726104 View commit details
    Browse the repository at this point in the history

  5. BasicIo::path() returns const ref

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    45300ad View commit details
    Browse the repository at this point in the history

  6. ReplaceStringInPlace does it in-place now

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    8b2d173 View commit details
    Browse the repository at this point in the history

  7. Use rename from filesystem

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    9b3a643 View commit details
    Browse the repository at this point in the history

  8. Use remove from filesystem

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    56b5ab9 View commit details
    Browse the repository at this point in the history

  9. Image::setComment now takes string_view

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    a6185d2 View commit details
    Browse the repository at this point in the history

  10. Remove dead code (winNumberOfLinks)

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    798cf9b View commit details
    Browse the repository at this point in the history

  11. Remove dead code (LSTAT)

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    c0b663b View commit details
    Browse the repository at this point in the history

  12. Remove dead code: copyXattrFrom

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    1d243ed View commit details
    Browse the repository at this point in the history

  13. Remove dead code

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    ea201ce View commit details
    Browse the repository at this point in the history

  14. Replace dynamic C array by std::vector

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    d11479e View commit details
    Browse the repository at this point in the history

  15. cppcheck: reduce scope of variables

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    59f4d0d View commit details
    Browse the repository at this point in the history

  16. Replace raw loop for any_of

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    476a5e2 View commit details
    Browse the repository at this point in the history

  17. Use filesystem in getExiv2ConfigPath 

    It seems to have an important impact in performance. The execution of
ctest on Windows passed from 48.5 secs to 43.8. Check if this is the
same on Linux
    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    b543f3e View commit details
    Browse the repository at this point in the history

  18. Remove many redundant or not needed header inclusions

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    7e5ba7c View commit details
    Browse the repository at this point in the history

  19. Use fs::file_size instead of stat

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    7caf409 View commit details
    Browse the repository at this point in the history

  20. Clean config.h from old stuff

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    f060b58 View commit details
    Browse the repository at this point in the history

  21. Clean more header inclusions

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    76f01fd View commit details
    Browse the repository at this point in the history

  22. Use standard [[maybe_unused]]

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    9fb43f2 View commit details
    Browse the repository at this point in the history

  23. Fix build on linux

    @piponazo
    piponazo committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    f774a3b View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2022

  1. Improvements from code review

    @piponazo
    piponazo committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    8b3da36 View commit details
    Browse the repository at this point in the history

  2. Fix build when EXIV2_BUILD_MESSAGES is ON

    @piponazo
    piponazo committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    21eb0ce View commit details
    Browse the repository at this point in the history