-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring & cleanup #2109
Refactoring & cleanup #2109
Conversation
It seems to have an important impact in performance. The execution of ctest on Windows passed from 48.5 secs to 43.8. Check if this is the same on Linux
@@ -278,6 +284,7 @@ namespace Exiv2 { | |||
return Image::byteSwap(v,bSwap); | |||
} | |||
|
|||
/// \todo not used internally. At least we should test it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added these comments in few places because cppcheck was detecting these functions as UNUSED ones. However they are part of the API and they should not be removed without further consideration.
6076baa
to
f774a3b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
+ Coverage 63.80% 63.98% +0.18%
==========================================
Files 96 97 +1
Lines 19169 19086 -83
Branches 9772 9752 -20
==========================================
- Hits 12230 12212 -18
+ Misses 4658 4599 -59
+ Partials 2281 2275 -6
Continue to review full report at Codecov.
|
8b86150
to
21eb0ce
Compare
Here it goes a bunch of totally unrelated changes with the aim of simplifying code and removing some dead code (take a look to the LoC deletions 😨 ). In case it is difficult to review so many changes, I can split the PR in few ones by different topics. Although I tried to keep different changes in isolated commits.
This is a list of the different actions taken here:
string_view
in some more places.