Linux distros jobs on PRs + Fix linking issues on some platforms

[piponazo]

Fixes #2100

[codecov]

Codecov Report

Merging #2101 (8cd8b3a) into main (287744f) will not change coverage.
The diff coverage is n/a.

❗ Current head 8cd8b3a differs from pull request most recent head b7d5c7e. Consider uploading reports for the commit b7d5c7e to get more accurate results

@@           Coverage Diff           @@
##             main    #2101   +/-   ##
=======================================
  Coverage   63.75%   63.75%           
=======================================
  Files          96       96           
  Lines       19202    19202           
  Branches     9798     9798           
=======================================
  Hits        12242    12242           
  Misses       4658     4658           
  Partials     2302     2302           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287744f...b7d5c7e. Read the comment docs.

[neheb]

Not quite correct.

For GCC 8 and clang 7-8, this is needed. GCC9 and clang9 and above do not. Well, the libc++ versions actually.

GCC7 supports std::experimental::filesystem which is basically boost::filesystem. I wouldn't bother with it though.

[piponazo]

Thanks for the detailed review! I'll be more explicit about those checks in the CMake code then.

[neheb]

This is how I do it elsewhere: gerbera/gerbera@143217b#diff-30d8f6be6320feeacf686be94f48c70869b52630e01ea625f0f15adc0d57c3e4R16
It's not cmake but it's easy to translate I think.

[piponazo]

This is how I do it elsewhere: gerbera/gerbera@143217b#diff-30d8f6be6320feeacf686be94f48c70869b52630e01ea625f0f15adc0d57c3e4R16
It's not cmake but it's easy to translate I think.

Just for the sake of sharing: There is a long discussion about this topic in a CMake gitlab issue:
https://gitlab.kitware.com/cmake/cmake/-/issues/17834

It seems difficult to come up with something very robust (for all possible cases). I'll try to come up with something good enough for the platforms we support in our CI infrastructure.

[neheb]

I forgot to mention one thing. On 32-bit OS, GCC 8.3 has a bug where std::filesystem does not work with larger than 2GB files. This was fixed with 8.4 I don't know if that's relevant. Debian 10 comes with GCC 8.3.

[piponazo]

I forgot to mention one thing. On 32-bit OS, GCC 8.3 has a bug where std::filesystem does not work with larger than 2GB files. This was fixed with 8.4 I don't know if that's relevant. Debian 10 comes with GCC 8.3.

Definitely it is good to know. I'm adding this link for future reference in case this bites us in the future:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91947