You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the "Nightly - Linux Distributions" builds is failing on the main branch after merging #2090. However, in that PR all the CI checks were passing.
Describe the solution you would like
It would be good to also trigger the "Linux Distributions" builds in PRs, so that we do not end up breaking something in mian without noticing in the PRs.
We would just need to change .github/workflows)/nightly_Linux_distributions.yml so that it runs on PRs.
Furthermore, we should fix the current issue on main. It is complaining about undefined references to std::filesystem:
[100%] Linking CXX executable ../bin/exiv2
CMakeFiles/exiv2.dir/actions.cpp.o: In function`(anonymous namespace)::metacopy(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, int, bool)':actions.cpp:(.text+0xa4e7): undefined reference to `std::filesystem::__cxx11::path::_M_split_cmpts()'
actions.cpp:(.text+0xa4f7): undefined reference to `std::filesystem::temp_directory_path[abi:cxx11]()'actions.cpp:(.text+0xa50f): undefined reference to `std::filesystem::__cxx11::path::has_root_directory() cons...
Running the entire workflow on PRs might be a lot. (It's 48 builds)
But I do think it makes sense to have a build of one of the older distros in the PR pipeline 👍
Is your feature request related to a problem?
I noticed that the "Nightly - Linux Distributions" builds is failing on the
main
branch after merging #2090. However, in that PR all the CI checks were passing.Describe the solution you would like
It would be good to also trigger the "Linux Distributions" builds in PRs, so that we do not end up breaking something in
mian
without noticing in the PRs.We would just need to change
.github/workflows)/nightly_Linux_distributions.yml
so that it runs on PRs.Furthermore, we should fix the current issue on
main
. It is complaining about undefined references tostd::filesystem
:Something like this should work.
The text was updated successfully, but these errors were encountered: