Fix RoomSpawnpoint #110
Open
Fix RoomSpawnpoint #110
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Preventing use of TransformPoint(Offset) in Surface Room * Added more delay
|
I fixed uwu @Josephfallen |
|
Thank you @SrLicht I'll look over it once I finish my code :) |
|
Thank you n-n I've already tested the changes and they work before my items appeared in Y 2000 and now they appear correctly in Surface |
|
@SrLicht If you want it reviewed you have to make it public |
iamalexrouse
suggested changes
Sep 24, 2024
Co-authored-by: Alex Rouse <alex@leronix.net>
* Thanks Alex Co-Authored-By: Alex Rouse <alex@leronix.net>
louis1706
approved these changes
Sep 30, 2024
SrLicht
requested review from
iamalexrouse,
louis1706,
Josephfallen and
VALERA771
After so much testing for a while, if CustomItems spawn too early they are not properly registered and spawn but without being custom items, also the locker spawn does not work because the base game did not finish generating all the lockers on the map yet, by adding this delay all those problems were eliminated. I also thought it was fair to add a Try catch Log.Error in case there is any error when spawning custom items, currently if there is any you have no way of knowing. Translated with DeepL.com (free version)
|
I was too lazy to type the commit from my damn cell phone so I used a translator. |
VALERA771
approved these changes
Oct 6, 2024
iamalexrouse
suggested changes
Oct 6, 2024
Co-authored-by: Alex Rouse <alex@leronix.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Fixes RoomSpawnPoint when used in Surface and also changing the spawn eventarg to WaitingForPlayers.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Proof what the change is working and dont brake the position
PillsSpawnPoints its a List of RoomSpawnPoints where some are in Surface
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other